Bug 1288992 Part 3 - Rename local variables named metrics to reflowOutput.
This patch is edited manually.
MozReview-Commit-ID: 1IsLGrgmDIY
--- a/layout/generic/nsBlockFrame.cpp
+++ b/layout/generic/nsBlockFrame.cpp
@@ -1230,40 +1230,40 @@ nsBlockFrame::Reflow(nsPresContext*
// contains a block (example: <LI>\n<P>... ). This is where
// the second case can happen.
if (HasOutsideBullet() && !mLines.empty() &&
(mLines.front()->IsBlock() ||
(0 == mLines.front()->BSize() &&
mLines.front() != mLines.back() &&
mLines.begin().next()->IsBlock()))) {
// Reflow the bullet
- ReflowOutput metrics(aReflowInput);
+ ReflowOutput reflowOutput(aReflowInput);
// XXX Use the entire line when we fix bug 25888.
nsLayoutUtils::LinePosition position;
WritingMode wm = aReflowInput.GetWritingMode();
bool havePosition = nsLayoutUtils::GetFirstLinePosition(wm, this,
&position);
nscoord lineBStart = havePosition ?
position.mBStart :
reflowInput->ComputedLogicalBorderPadding().BStart(wm);
nsIFrame* bullet = GetOutsideBullet();
- ReflowBullet(bullet, state, metrics, lineBStart);
- NS_ASSERTION(!BulletIsEmpty() || metrics.BSize(wm) == 0,
+ ReflowBullet(bullet, state, reflowOutput, lineBStart);
+ NS_ASSERTION(!BulletIsEmpty() || reflowOutput.BSize(wm) == 0,
"empty bullet took up space");
if (havePosition && !BulletIsEmpty()) {
// We have some lines to align the bullet with.
// Doing the alignment using the baseline will also cater for
// bullets that are placed next to a child block (bug 92896)
// Tall bullets won't look particularly nice here...
- LogicalRect bbox = bullet->GetLogicalRect(wm, metrics.PhysicalSize());
- bbox.BStart(wm) = position.mBaseline - metrics.BlockStartAscent();
- bullet->SetRect(wm, bbox, metrics.PhysicalSize());
+ LogicalRect bbox = bullet->GetLogicalRect(wm, reflowOutput.PhysicalSize());
+ bbox.BStart(wm) = position.mBaseline - reflowOutput.BlockStartAscent();
+ bullet->SetRect(wm, bbox, reflowOutput.PhysicalSize());
}
// Otherwise just leave the bullet where it is, up against our
// block-start padding.
}
CheckFloats(state);
// Compute our final size
--- a/layout/generic/nsBulletFrame.cpp
+++ b/layout/generic/nsBulletFrame.cpp
@@ -670,22 +670,22 @@ nsBulletFrame::Reflow(nsPresContext* aPr
aStatus = NS_FRAME_COMPLETE;
NS_FRAME_SET_TRUNCATION(aStatus, aReflowInput, aMetrics);
}
/* virtual */ nscoord
nsBulletFrame::GetMinISize(nsRenderingContext *aRenderingContext)
{
WritingMode wm = GetWritingMode();
- ReflowOutput metrics(wm);
- DISPLAY_MIN_WIDTH(this, metrics.ISize(wm));
+ ReflowOutput reflowOutput(wm);
+ DISPLAY_MIN_WIDTH(this, reflowOutput.ISize(wm));
LogicalMargin padding(wm);
- GetDesiredSize(PresContext(), aRenderingContext, metrics, 1.0f, &padding);
- metrics.ISize(wm) += padding.IStartEnd(wm);
- return metrics.ISize(wm);
+ GetDesiredSize(PresContext(), aRenderingContext, reflowOutput, 1.0f, &padding);
+ reflowOutput.ISize(wm) += padding.IStartEnd(wm);
+ return reflowOutput.ISize(wm);
}
/* virtual */ nscoord
nsBulletFrame::GetPrefISize(nsRenderingContext *aRenderingContext)
{
WritingMode wm = GetWritingMode();
ReflowOutput metrics(wm);
DISPLAY_PREF_WIDTH(this, metrics.ISize(wm));
--- a/layout/generic/nsFrameSetFrame.cpp
+++ b/layout/generic/nsFrameSetFrame.cpp
@@ -687,29 +687,29 @@ nsHTMLFramesetFrame::ReflowPlaceChild(ns
nsSize& aSize,
nsIntPoint* aCellIndex)
{
// reflow the child
ReflowInput reflowInput(aPresContext, aReflowInput, aChild,
LogicalSize(aChild->GetWritingMode(), aSize));
reflowInput.SetComputedWidth(std::max(0, aSize.width - reflowInput.ComputedPhysicalBorderPadding().LeftRight()));
reflowInput.SetComputedHeight(std::max(0, aSize.height - reflowInput.ComputedPhysicalBorderPadding().TopBottom()));
- ReflowOutput metrics(aReflowInput);
- metrics.Width() = aSize.width;
- metrics.Height() = aSize.height;
+ ReflowOutput reflowOutput(aReflowInput);
+ reflowOutput.Width() = aSize.width;
+ reflowOutput.Height() = aSize.height;
nsReflowStatus status;
- ReflowChild(aChild, aPresContext, metrics, reflowInput, aOffset.x,
+ ReflowChild(aChild, aPresContext, reflowOutput, reflowInput, aOffset.x,
aOffset.y, 0, status);
NS_ASSERTION(NS_FRAME_IS_COMPLETE(status), "bad status");
// Place and size the child
- metrics.Width() = aSize.width;
- metrics.Height() = aSize.height;
- FinishReflowChild(aChild, aPresContext, metrics, nullptr, aOffset.x, aOffset.y, 0);
+ reflowOutput.Width() = aSize.width;
+ reflowOutput.Height() = aSize.height;
+ FinishReflowChild(aChild, aPresContext, reflowOutput, nullptr, aOffset.x, aOffset.y, 0);
}
static
nsFrameborder GetFrameBorderHelper(nsGenericHTMLElement* aContent)
{
if (nullptr != aContent) {
const nsAttrValue* attr = aContent->GetParsedAttr(nsGkAtoms::frameborder);
if (attr && attr->Type() == nsAttrValue::eEnum) {
--- a/layout/generic/nsLineLayout.cpp
+++ b/layout/generic/nsLineLayout.cpp
@@ -919,38 +919,38 @@ nsLineLayout::ReflowFrame(nsIFrame* aFra
if (mGotLineBox && IsPercentageAware(aFrame)) {
mLineBox->DisableResizeReflowOptimization();
}
// Note that we don't bother positioning the frame yet, because we're probably
// going to end up moving it when we do the block-direction alignment.
// Adjust spacemanager coordinate system for the frame.
- ReflowOutput metrics(lineWM);
+ ReflowOutput reflowOutput(lineWM);
#ifdef DEBUG
- metrics.ISize(lineWM) = nscoord(0xdeadbeef);
- metrics.BSize(lineWM) = nscoord(0xdeadbeef);
+ reflowOutput.ISize(lineWM) = nscoord(0xdeadbeef);
+ reflowOutput.BSize(lineWM) = nscoord(0xdeadbeef);
#endif
nscoord tI = pfd->mBounds.LineLeft(lineWM, ContainerSize());
nscoord tB = pfd->mBounds.BStart(lineWM);
mFloatManager->Translate(tI, tB);
int32_t savedOptionalBreakOffset;
gfxBreakPriority savedOptionalBreakPriority;
nsIFrame* savedOptionalBreakFrame =
GetLastOptionalBreakPosition(&savedOptionalBreakOffset,
&savedOptionalBreakPriority);
if (!isText) {
- aFrame->Reflow(mPresContext, metrics, *reflowInputHolder, aReflowStatus);
+ aFrame->Reflow(mPresContext, reflowOutput, *reflowInputHolder, aReflowStatus);
} else {
static_cast<nsTextFrame*>(aFrame)->
ReflowText(*this, availableSpaceOnLine,
psd->mReflowInput->mRenderingContext->GetDrawTarget(),
- metrics, aReflowStatus);
+ reflowOutput, aReflowStatus);
}
pfd->mJustificationInfo = mJustificationInfo;
mJustificationInfo = JustificationInfo();
// See if the frame is a placeholderFrame and if it is process
// the float. At the same time, check if the frame has any non-collapsed-away
// content.
@@ -1015,65 +1015,65 @@ nsLineLayout::ReflowFrame(nsIFrame* aFra
isEmpty = pfd->mFrame->IsEmpty();
}
}
}
pfd->mIsEmpty = isEmpty;
mFloatManager->Translate(-tI, -tB);
- NS_ASSERTION(metrics.ISize(lineWM) >= 0, "bad inline size");
- NS_ASSERTION(metrics.BSize(lineWM) >= 0,"bad block size");
- if (metrics.ISize(lineWM) < 0) {
- metrics.ISize(lineWM) = 0;
+ NS_ASSERTION(reflowOutput.ISize(lineWM) >= 0, "bad inline size");
+ NS_ASSERTION(reflowOutput.BSize(lineWM) >= 0,"bad block size");
+ if (reflowOutput.ISize(lineWM) < 0) {
+ reflowOutput.ISize(lineWM) = 0;
}
- if (metrics.BSize(lineWM) < 0) {
- metrics.BSize(lineWM) = 0;
+ if (reflowOutput.BSize(lineWM) < 0) {
+ reflowOutput.BSize(lineWM) = 0;
}
#ifdef DEBUG
// Note: break-before means ignore the reflow metrics since the
// frame will be reflowed another time.
if (!NS_INLINE_IS_BREAK_BEFORE(aReflowStatus)) {
- if ((CRAZY_SIZE(metrics.ISize(lineWM)) ||
- CRAZY_SIZE(metrics.BSize(lineWM))) &&
+ if ((CRAZY_SIZE(reflowOutput.ISize(lineWM)) ||
+ CRAZY_SIZE(reflowOutput.BSize(lineWM))) &&
!LineContainerFrame()->GetParent()->IsCrazySizeAssertSuppressed()) {
printf("nsLineLayout: ");
nsFrame::ListTag(stdout, aFrame);
- printf(" metrics=%d,%d!\n", metrics.Width(), metrics.Height());
+ printf(" metrics=%d,%d!\n", reflowOutput.Width(), reflowOutput.Height());
}
- if ((metrics.Width() == nscoord(0xdeadbeef)) ||
- (metrics.Height() == nscoord(0xdeadbeef))) {
+ if ((reflowOutput.Width() == nscoord(0xdeadbeef)) ||
+ (reflowOutput.Height() == nscoord(0xdeadbeef))) {
printf("nsLineLayout: ");
nsFrame::ListTag(stdout, aFrame);
- printf(" didn't set w/h %d,%d!\n", metrics.Width(), metrics.Height());
+ printf(" didn't set w/h %d,%d!\n", reflowOutput.Width(), reflowOutput.Height());
}
}
#endif
// Unlike with non-inline reflow, the overflow area here does *not*
// include the accumulation of the frame's bounds and its inline
// descendants' bounds. Nor does it include the outline area; it's
// just the union of the bounds of any absolute children. That is
// added in later by nsLineLayout::ReflowInlineFrames.
- pfd->mOverflowAreas = metrics.mOverflowAreas;
+ pfd->mOverflowAreas = reflowOutput.mOverflowAreas;
- pfd->mBounds.ISize(lineWM) = metrics.ISize(lineWM);
- pfd->mBounds.BSize(lineWM) = metrics.BSize(lineWM);
+ pfd->mBounds.ISize(lineWM) = reflowOutput.ISize(lineWM);
+ pfd->mBounds.BSize(lineWM) = reflowOutput.BSize(lineWM);
// Size the frame, but |RelativePositionFrames| will size the view.
aFrame->SetRect(lineWM, pfd->mBounds, ContainerSizeForSpan(psd));
// Tell the frame that we're done reflowing it
aFrame->DidReflow(mPresContext,
isText ? nullptr : reflowInputHolder.ptr(),
nsDidReflowStatus::FINISHED);
if (aMetrics) {
- *aMetrics = metrics;
+ *aMetrics = reflowOutput;
}
if (!NS_INLINE_IS_BREAK_BEFORE(aReflowStatus)) {
// If frame is complete and has a next-in-flow, we need to delete
// them now. Do not do this when a break-before is signaled because
// the frame is going to get reflowed again (and may end up wanting
// a next-in-flow where it ends up).
if (NS_FRAME_IS_COMPLETE(aReflowStatus)) {
@@ -1099,17 +1099,17 @@ nsLineLayout::ReflowFrame(nsIFrame* aFra
// See if we can place the frame. If we can't fit it, then we
// return now.
bool optionalBreakAfterFits;
NS_ASSERTION(isText ||
!reflowInputHolder->IsFloating(),
"How'd we get a floated inline frame? "
"The frame ctor should've dealt with this.");
if (CanPlaceFrame(pfd, notSafeToBreak, continuingTextRun,
- savedOptionalBreakFrame != nullptr, metrics,
+ savedOptionalBreakFrame != nullptr, reflowOutput,
aReflowStatus, &optionalBreakAfterFits)) {
if (!isEmpty) {
psd->mHasNonemptyContent = true;
mLineIsEmpty = false;
if (!pfd->mSpan) {
// nonempty leaf content has been placed
mLineAtStart = false;
}
@@ -1117,17 +1117,17 @@ nsLineLayout::ReflowFrame(nsIFrame* aFra
mHasRuby = true;
SyncAnnotationBounds(pfd);
}
}
// Place the frame, updating aBounds with the final size and
// location. Then apply the bottom+right margins (as
// appropriate) to the frame.
- PlaceFrame(pfd, metrics);
+ PlaceFrame(pfd, reflowOutput);
PerSpanData* span = pfd->mSpan;
if (span) {
// The frame we just finished reflowing is an inline
// container. It needs its child frames aligned in the block direction,
// so do most of it now.
VerticalAlignFrames(span);
}
--- a/layout/mathml/nsMathMLContainerFrame.cpp
+++ b/layout/mathml/nsMathMLContainerFrame.cpp
@@ -127,40 +127,40 @@ IsForeignChild(const nsIFrame* aFrame)
NS_DECLARE_FRAME_PROPERTY_DELETABLE(HTMLReflowOutputProperty,
ReflowOutput)
/* static */ void
nsMathMLContainerFrame::SaveReflowAndBoundingMetricsFor(nsIFrame* aFrame,
const ReflowOutput& aReflowOutput,
const nsBoundingMetrics& aBoundingMetrics)
{
- ReflowOutput *metrics = new ReflowOutput(aReflowOutput);
- metrics->mBoundingMetrics = aBoundingMetrics;
- aFrame->Properties().Set(HTMLReflowOutputProperty(), metrics);
+ ReflowOutput* reflowOutput = new ReflowOutput(aReflowOutput);
+ reflowOutput->mBoundingMetrics = aBoundingMetrics;
+ aFrame->Properties().Set(HTMLReflowOutputProperty(), reflowOutput);
}
// helper method to facilitate getting the reflow and bounding metrics
/* static */ void
nsMathMLContainerFrame::GetReflowAndBoundingMetricsFor(nsIFrame* aFrame,
ReflowOutput& aReflowOutput,
nsBoundingMetrics& aBoundingMetrics,
eMathMLFrameType* aMathMLFrameType)
{
NS_PRECONDITION(aFrame, "null arg");
- ReflowOutput* metrics =
+ ReflowOutput* reflowOutput =
aFrame->Properties().Get(HTMLReflowOutputProperty());
// IMPORTANT: This function is only meant to be called in Place() methods
// where it is assumed that SaveReflowAndBoundingMetricsFor has recorded the
// information.
- NS_ASSERTION(metrics, "Didn't SaveReflowAndBoundingMetricsFor frame!");
- if (metrics) {
- aReflowOutput = *metrics;
- aBoundingMetrics = metrics->mBoundingMetrics;
+ NS_ASSERTION(reflowOutput, "Didn't SaveReflowAndBoundingMetricsFor frame!");
+ if (reflowOutput) {
+ aReflowOutput = *reflowOutput;
+ aBoundingMetrics = reflowOutput->mBoundingMetrics;
}
if (aMathMLFrameType) {
if (!IsForeignChild(aFrame)) {
nsIMathMLFrame* mathMLFrame = do_QueryFrame(aFrame);
if (mathMLFrame) {
*aMathMLFrameType = mathMLFrame->GetMathMLFrameType();
return;
@@ -191,19 +191,19 @@ nsMathMLContainerFrame::GetPreferredStre
nsBoundingMetrics& aPreferredStretchSize)
{
if (aOptions & STRETCH_CONSIDER_ACTUAL_SIZE) {
// when our actual size is ok, just use it
aPreferredStretchSize = mBoundingMetrics;
}
else if (aOptions & STRETCH_CONSIDER_EMBELLISHMENTS) {
// compute our up-to-date size using Place()
- ReflowOutput metrics(GetWritingMode()); // ???
- Place(aDrawTarget, false, metrics);
- aPreferredStretchSize = metrics.mBoundingMetrics;
+ ReflowOutput reflowOutput(GetWritingMode());
+ Place(aDrawTarget, false, reflowOutput);
+ aPreferredStretchSize = reflowOutput.mBoundingMetrics;
}
else {
// compute a size that includes embellishments iff the container stretches
// in the same direction as the embellished operator.
bool stretchAll = aStretchDirection == NS_STRETCH_DIRECTION_VERTICAL ?
NS_MATHML_WILL_STRETCH_ALL_CHILDREN_VERTICALLY(mPresentationData.flags) :
NS_MATHML_WILL_STRETCH_ALL_CHILDREN_HORIZONTALLY(mPresentationData.flags);
NS_ASSERTION(aStretchDirection == NS_STRETCH_DIRECTION_HORIZONTAL ||