Bug 1287706 part 2 - Remove useless runtime check of EventListenerManager::Listener. r?smaug draft
authorXidorn Quan <me@upsuper.org>
Mon, 25 Jul 2016 15:23:46 +1000
changeset 393142 c7029a7736542b1bcb6f6da9611cae9dc2b400a9
parent 393141 33825d312ef4d2ac97c6b4e3aa3828aee92a97b6
child 393143 fca3ba666b2b2258c9c2e353bd48faea8596294c
push id24227
push userxquan@mozilla.com
push dateWed, 27 Jul 2016 03:45:39 +0000
reviewerssmaug
bugs1287706
milestone50.0a1
Bug 1287706 part 2 - Remove useless runtime check of EventListenerManager::Listener. r?smaug MozReview-Commit-ID: 3XEfeF03Umx
dom/events/EventListenerManager.h
--- a/dom/events/EventListenerManager.h
+++ b/dom/events/EventListenerManager.h
@@ -184,39 +184,34 @@ public:
     EventMessage mEventMessage;
 
     enum ListenerType : uint8_t
     {
       eNativeListener = 0,
       eJSEventListener,
       eWrappedJSListener,
       eWebIDLListener,
-      eListenerTypeCount
     };
-    uint8_t mListenerType;
+    ListenerType mListenerType;
 
     bool mListenerIsHandler : 1;
     bool mHandlerIsString : 1;
     bool mAllEvents : 1;
     bool mIsChrome : 1;
 
     EventListenerFlags mFlags;
 
     JSEventHandler* GetJSEventHandler() const
     {
       return (mListenerType == eJSEventListener) ?
         static_cast<JSEventHandler*>(mListener.GetXPCOMCallback()) :
         nullptr;
     }
 
-    Listener()
-    {
-      MOZ_ASSERT(sizeof(mListenerType) == 1);
-      MOZ_ASSERT(eListenerTypeCount < 255);
-    }
+    Listener() = default;
 
     ~Listener()
     {
       if ((mListenerType == eJSEventListener) && mListener) {
         static_cast<JSEventHandler*>(
           mListener.GetXPCOMCallback())->Disconnect();
       }
     }