Bug 1289235 - Fix failing msvc compilation for PlatformHandleHelper implicit conversion. r?billm draft
authorBryce Van Dyk <bvandyk@mozilla.com>
Tue, 26 Jul 2016 10:04:39 +1200
changeset 392641 04a97844b013f378eafc63df47e7b2b015492494
parent 392445 251fccc1f62bf0eac569ef4f6717fea61ebadb27
child 392720 bdd940e3f6fce235b026d92abe034f034c140e89
child 392774 5b4ebc48c2b2a5f9404d91c52ae61c95c3de9529
child 392775 dbf7e3dc2a6b5a9d1158630661a021eb050ebd70
push id24069
push userbvandyk@mozilla.com
push dateMon, 25 Jul 2016 22:05:47 +0000
reviewersbillm
bugs1289235
milestone50.0a1
Bug 1289235 - Fix failing msvc compilation for PlatformHandleHelper implicit conversion. r?billm MSVC requires explict namespacing on for the implicit conversion, which is added in this changeset. MozReview-Commit-ID: 2xRN1gUtSlx
ipc/glue/FileDescriptor.cpp
--- a/ipc/glue/FileDescriptor.cpp
+++ b/ipc/glue/FileDescriptor.cpp
@@ -202,17 +202,17 @@ FileDescriptor::PlatformHandleHelper::Pl
 }
 
 bool
 FileDescriptor::PlatformHandleHelper::operator!=(std::nullptr_t) const
 {
   return mHandle != INVALID_HANDLE;
 }
 
-FileDescriptor::PlatformHandleHelper::operator PlatformHandleType () const
+FileDescriptor::PlatformHandleHelper::operator FileDescriptor::PlatformHandleType () const
 {
   return mHandle;
 }
 
 #ifdef XP_WIN
 FileDescriptor::PlatformHandleHelper::operator std::intptr_t () const
 {
   return reinterpret_cast<std::intptr_t>(mHandle);