Bug 1289007 - part0: remove redundant codes in ParsePropertyByFunction. draft
authorJeremy Chen <jeremychen@mozilla.com>
Thu, 28 Jul 2016 15:23:36 +0800
changeset 393679 72f31eee3cce0f854747a8284472bb93e0e44b0b
parent 393484 db3ed1fdbbeaf5ab1e8fe454780146e7499be3db
child 393680 13e450ca5d19eb48490f1a574245a084339e60a1
push id24373
push userjichen@mozilla.com
push dateThu, 28 Jul 2016 07:24:05 +0000
bugs1289007
milestone50.0a1
Bug 1289007 - part0: remove redundant codes in ParsePropertyByFunction. CSS align and CSS justify share same parsing function under some conditions. Let's make these switch branches stick together, so we can remove a bit redundant codes. MozReview-Commit-ID: 49IKvqhLSt4
layout/style/nsCSSParser.cpp
--- a/layout/style/nsCSSParser.cpp
+++ b/layout/style/nsCSSParser.cpp
@@ -11558,27 +11558,25 @@ CSSParserImpl::ParsePropertyByFunction(n
                               eCSSProperty_grid_row_end);
   case eCSSProperty_grid_area:
     return ParseGridArea();
   case eCSSProperty_grid_gap:
     return ParseGridGap();
   case eCSSProperty_image_region:
     return ParseRect(eCSSProperty_image_region);
   case eCSSProperty_align_content:
+  case eCSSProperty_justify_content:
     return ParseAlignJustifyContent(aPropID);
   case eCSSProperty_align_items:
     return ParseAlignItems();
   case eCSSProperty_align_self:
+  case eCSSProperty_justify_self:
     return ParseAlignJustifySelf(aPropID);
-  case eCSSProperty_justify_content:
-    return ParseAlignJustifyContent(aPropID);
   case eCSSProperty_justify_items:
     return ParseJustifyItems();
-  case eCSSProperty_justify_self:
-    return ParseAlignJustifySelf(aPropID);
   case eCSSProperty_list_style:
     return ParseListStyle();
   case eCSSProperty_margin:
     return ParseMargin();
   case eCSSProperty_object_position:
     return ParseObjectPosition();
   case eCSSProperty_outline:
     return ParseOutline();