Bug 1282289 - Crash when using Android add-on/HelperApps .r=nalexander@mozilla.com draft
authordragoslav.mlakar <dragoslav.mlakar@gmail.com>
Sun, 24 Jul 2016 14:23:31 +0200
changeset 392191 80f8eb86d051bb8d62035df741f004e08ec5ab91
parent 391073 5910a5ced959527375eea77c194bb0ff81d8ee6b
child 393606 a7653f0439cbe7a45fc8a6d34c69bf7980bb256d
push id23956
push userbmo:dragoslav.mlakar@gmail.com
push dateSun, 24 Jul 2016 12:49:22 +0000
reviewersnalexander
bugs1282289
milestone50.0a1
Bug 1282289 - Crash when using Android add-on/HelperApps .r=nalexander@mozilla.com MozReview-Commit-ID: BFxB40vmqgH
mobile/android/base/java/org/mozilla/gecko/IntentHelper.java
--- a/mobile/android/base/java/org/mozilla/gecko/IntentHelper.java
+++ b/mobile/android/base/java/org/mozilla/gecko/IntentHelper.java
@@ -585,18 +585,26 @@ public final class IntentHelper implemen
         }
 
         @Override
         public void onActivityResult(int resultCode, Intent data) {
             JSONObject response = new JSONObject();
 
             try {
                 if (data != null) {
-                    response.put("extras", JSONUtils.bundleToJSON(data.getExtras()));
-                    response.put("uri", data.getData().toString());
+                    if (data.getExtras() != null) {
+                        response.put("extras", JSONUtils.bundleToJSON(data.getExtras()));
+                    } else {
+                        response.put("extras", null);
+                    }
+                    if (data.getData() != null) {
+                        response.put("uri", data.getData().toString());
+                    } else {
+                        response.put("uri", null);
+                    }
                 }
 
                 response.put("resultCode", resultCode);
             } catch (JSONException e) {
                 Log.w(LOGTAG, "Error building JSON response.", e);
             }
 
             EventDispatcher.sendResponse(message, response);