Bug 1201363 - Adding Add/RemoveVideoOutput into VideoStreamTrack. r?jesup
MozReview-Commit-ID: JmKotuB3pBM
--- a/dom/html/HTMLMediaElement.cpp
+++ b/dom/html/HTMLMediaElement.cpp
@@ -3625,27 +3625,41 @@ void HTMLMediaElement::UpdateSrcMediaStr
stream->AddAudioOutput(this);
SetVolumeInternal();
VideoFrameContainer* container = GetVideoFrameContainer();
if (container) {
stream->AddVideoOutput(container);
}
+ VideoTrack* videoTrack = VideoTracks()->GetSelectedTrack();
+ if (videoTrack) {
+ VideoStreamTrack* videoStreamTrack = videoTrack->GetVideoStreamTrack();
+ if (videoStreamTrack && container) {
+ videoStreamTrack->AddVideoOutput(container);
+ }
+ }
} else {
if (stream) {
mSrcStreamPausedCurrentTime = CurrentTime();
stream->RemoveListener(mMediaStreamListener);
stream->RemoveAudioOutput(this);
VideoFrameContainer* container = GetVideoFrameContainer();
if (container) {
stream->RemoveVideoOutput(container);
}
+ VideoTrack* videoTrack = VideoTracks()->GetSelectedTrack();
+ if (videoTrack) {
+ VideoStreamTrack* videoStreamTrack = videoTrack->GetVideoStreamTrack();
+ if (videoStreamTrack && container) {
+ videoStreamTrack->RemoveVideoOutput(container);
+ }
+ }
}
// If stream is null, then DOMMediaStream::Destroy must have been
// called and that will remove all listeners/outputs.
mWatchManager.Unwatch(*mMediaStreamListener,
&HTMLMediaElement::UpdateReadyStateInternal);
mMediaStreamListener->Forget();
--- a/dom/media/VideoStreamTrack.cpp
+++ b/dom/media/VideoStreamTrack.cpp
@@ -1,20 +1,35 @@
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*-*/
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "VideoStreamTrack.h"
+#include "MediaStreamVideoSink.h"
+#include "MediaStreamGraph.h"
+
#include "mozilla/dom/VideoStreamTrackBinding.h"
namespace mozilla {
namespace dom {
JSObject*
VideoStreamTrack::WrapObject(JSContext* aCx, JS::Handle<JSObject*> aGivenProto)
{
return VideoStreamTrackBinding::Wrap(aCx, this, aGivenProto);
}
+void
+VideoStreamTrack::AddVideoOutput(MediaStreamVideoSink* aSink)
+{
+ GetOwnedStream()->AddVideoOutput(aSink, mTrackID);
+}
+
+void
+VideoStreamTrack::RemoveVideoOutput(MediaStreamVideoSink* aSink)
+{
+ GetOwnedStream()->RemoveVideoOutput(aSink, mTrackID);
+}
+
} // namespace dom
} // namespace mozilla
--- a/dom/media/VideoStreamTrack.h
+++ b/dom/media/VideoStreamTrack.h
@@ -5,32 +5,38 @@
#ifndef VIDEOSTREAMTRACK_H_
#define VIDEOSTREAMTRACK_H_
#include "MediaStreamTrack.h"
#include "DOMMediaStream.h"
namespace mozilla {
+
+class MediaStreamVideoSink;
+
namespace dom {
class VideoStreamTrack : public MediaStreamTrack {
public:
VideoStreamTrack(DOMMediaStream* aStream, TrackID aTrackID,
TrackID aInputTrackID,
MediaStreamTrackSource* aSource,
const MediaTrackConstraints& aConstraints = MediaTrackConstraints())
: MediaStreamTrack(aStream, aTrackID, aInputTrackID, aSource, aConstraints) {}
JSObject* WrapObject(JSContext* aCx, JS::Handle<JSObject*> aGivenProto) override;
VideoStreamTrack* AsVideoStreamTrack() override { return this; }
const VideoStreamTrack* AsVideoStreamTrack() const override { return this; }
+ void AddVideoOutput(MediaStreamVideoSink* aSink);
+ void RemoveVideoOutput(MediaStreamVideoSink* aSink);
+
// WebIDL
void GetKind(nsAString& aKind) override { aKind.AssignLiteral("video"); }
protected:
already_AddRefed<MediaStreamTrack> CloneInternal(DOMMediaStream* aOwningStream,
TrackID aTrackID) override
{
return do_AddRef(new VideoStreamTrack(aOwningStream,
--- a/dom/media/VideoTrackList.cpp
+++ b/dom/media/VideoTrackList.cpp
@@ -60,16 +60,25 @@ VideoTrackList::RemoveTrack(const RefPtr
void
VideoTrackList::EmptyTracks()
{
mSelectedIndex = -1;
MediaTrackList::EmptyTracks();
}
+VideoTrack* VideoTrackList::GetSelectedTrack()
+{
+ if (mSelectedIndex < 0 || static_cast<size_t>(mSelectedIndex) >= mTracks.Length()) {
+ return nullptr;
+ }
+
+ return operator[](mSelectedIndex);
+}
+
VideoTrack*
VideoTrackList::IndexedGetter(uint32_t aIndex, bool& aFound)
{
MediaTrack* track = MediaTrackList::IndexedGetter(aIndex, aFound);
return track ? track->AsVideoTrack() : nullptr;
}
VideoTrack*
--- a/dom/media/VideoTrackList.h
+++ b/dom/media/VideoTrackList.h
@@ -27,16 +27,18 @@ public:
JSObject* WrapObject(JSContext* aCx, JS::Handle<JSObject*> aGivenProto) override;
VideoTrack* operator[](uint32_t aIndex);
void RemoveTrack(const RefPtr<MediaTrack>& aTrack) override;
void EmptyTracks() override;
+ VideoTrack* GetSelectedTrack();
+
// WebIDL
int32_t SelectedIndex() const
{
return mSelectedIndex;
}
VideoTrack* IndexedGetter(uint32_t aIndex, bool& aFound);