Bug 1286676 - Part 1: Match current markup in pageError. r=bgrins draft
authorLin Clark <lclark@mozilla.com>
Wed, 29 Jun 2016 21:10:50 -0400
changeset 391355 e916fecb376ab7feb14636b574a3a26d7f152bd5
parent 391305 e0bc88708ffed39aaab1fbc0ac461d93561195de
child 391356 14f8ff37b6f8b5afbfec7d22bc6bc4c4b2a87bc7
push id23882
push userbmo:lclark@mozilla.com
push dateFri, 22 Jul 2016 14:54:29 +0000
reviewersbgrins
bugs1286676
milestone50.0a1
Bug 1286676 - Part 1: Match current markup in pageError. r=bgrins
devtools/client/webconsole/new-console-output/components/message-types/page-error.js
devtools/client/webconsole/new-console-output/test/components/test_page-error.html
--- a/devtools/client/webconsole/new-console-output/components/message-types/page-error.js
+++ b/devtools/client/webconsole/new-console-output/components/message-types/page-error.js
@@ -18,39 +18,32 @@ const MessageIcon = createFactory(requir
 PageError.displayName = "PageError";
 
 PageError.propTypes = {
   message: PropTypes.object.isRequired,
 };
 
 function PageError(props) {
   const { message } = props;
-  const messageBody =
-    dom.span({className: "message-body devtools-monospace"},
-      message.data.errorMessage);
   const repeat = MessageRepeat({repeat: message.repeat});
   const icon = MessageIcon({severity: message.severity});
-  const children = [
-    messageBody,
-    repeat
-  ];
 
   // @TODO Use of "is" is a temporary hack to get the category and severity
   // attributes to be applied. There are targeted in webconsole's CSS rules,
   // so if we remove this hack, we have to modify the CSS rules accordingly.
   return dom.div({
-    class: "message cm-s-mozilla",
+    class: "message",
     is: "fdt-message",
     category: message.category,
     severity: message.severity
   },
     icon,
-    dom.span({className: "message-body-wrapper"},
+    dom.span(
+      {className: "message-body-wrapper message-body devtools-monospace"},
       dom.span({},
-        dom.span({className: "message-flex-body"},
-          children
-        )
+        message.data.errorMessage
       )
-    )
+    ),
+    repeat
   );
 }
 
 module.exports.PageError = PageError;
--- a/devtools/client/webconsole/new-console-output/test/components/test_page-error.html
+++ b/devtools/client/webconsole/new-console-output/test/components/test_page-error.html
@@ -15,17 +15,17 @@
 window.onload = Task.async(function* () {
   const { prepareMessage } = require("devtools/client/webconsole/new-console-output/utils/messages");
   const { PageError } = require("devtools/client/webconsole/new-console-output/components/message-types/page-error");
 
   const packet = yield getPacket(null, "pageError");
   const message = prepareMessage(packet);
   const rendered = renderComponent(PageError, {message});
 
-  const queryPath = "div.message.cm-s-mozilla span span.message-flex-body span.message-body.devtools-monospace";
+  const queryPath = "div.message span.message-body-wrapper.message-body.devtools-monospace";
   const messageBody = rendered.querySelectorAll(queryPath);
   is(messageBody.length, 1, "PageError outputs expected HTML structure");
   is(messageBody[0].textContent, testCommands.get("pageError").expectedText, "PageError outputs expected text");
 
   SimpleTest.finish()
 });
 </script>
 </body>