Bug 1288625 - Part 1. Allow compiling of ipc/chromium for Android 64-bit. r=billm draft
authorMakoto Kato <m_kato@ga2.so-net.ne.jp>
Fri, 22 Jul 2016 15:28:53 +0900
changeset 404855 5b1248ee9e9c2ca003c06bd6ef889d632acfea50
parent 404830 d015148149e85fe4b3769f3edf7108b89fe57520
child 404856 b374032d58c9107f35f715dd0775e262bbd79cf3
push id27332
push userm_kato@ga2.so-net.ne.jp
push dateWed, 24 Aug 2016 09:32:14 +0000
reviewersbillm
bugs1288625
milestone51.0a1
Bug 1288625 - Part 1. Allow compiling of ipc/chromium for Android 64-bit. r=billm MozReview-Commit-ID: Fyv21xmrGXl
ipc/chromium/src/base/condition_variable_posix.cc
ipc/chromium/src/base/time_posix.cc
--- a/ipc/chromium/src/base/condition_variable_posix.cc
+++ b/ipc/chromium/src/base/condition_variable_posix.cc
@@ -15,17 +15,18 @@
 #include "base/time.h"
 
 using base::Time;
 using base::TimeDelta;
 
 ConditionVariable::ConditionVariable(Lock* user_lock)
     : user_mutex_(user_lock->lock_impl()->os_lock()) {
   int rv = 0;
-#if !defined(OS_MACOSX) && !defined(OS_ANDROID)
+#if !defined(OS_MACOSX) && \
+    !(defined(OS_ANDROID) && defined(HAVE_PTHREAD_COND_TIMEDWAIT_MONOTONIC))
   pthread_condattr_t attrs;
   rv = pthread_condattr_init(&attrs);
   DCHECK_EQ(0, rv);
   pthread_condattr_setclock(&attrs, CLOCK_MONOTONIC);
   rv = pthread_cond_init(&condition_, &attrs);
   pthread_condattr_destroy(&attrs);
 #else
   rv = pthread_cond_init(&condition_, NULL);
@@ -63,22 +64,22 @@ void ConditionVariable::TimedWait(const 
   absolute_time.tv_sec = now.tv_sec;
   absolute_time.tv_nsec = now.tv_nsec;
   absolute_time.tv_sec += relative_time.tv_sec;
   absolute_time.tv_nsec += relative_time.tv_nsec;
   absolute_time.tv_sec += absolute_time.tv_nsec / Time::kNanosecondsPerSecond;
   absolute_time.tv_nsec %= Time::kNanosecondsPerSecond;
   DCHECK_GE(absolute_time.tv_sec, now.tv_sec);  // Overflow paranoia
 
-#if defined(OS_ANDROID)
+#if defined(OS_ANDROID) && defined(HAVE_PTHREAD_COND_TIMEDWAIT_MONOTONIC)
   int rv = pthread_cond_timedwait_monotonic_np(
       &condition_, user_mutex_, &absolute_time);
 #else
   int rv = pthread_cond_timedwait(&condition_, user_mutex_, &absolute_time);
-#endif  // OS_ANDROID
+#endif  // OS_ANDROID && HAVE_PTHREAD_COND_TIMEDWAIT_MONOTONIC
 #endif  // OS_MACOSX
 
   DCHECK(rv == 0 || rv == ETIMEDOUT);
 }
 
 void ConditionVariable::Broadcast() {
   int rv = pthread_cond_broadcast(&condition_);
   DCHECK(rv == 0);
--- a/ipc/chromium/src/base/time_posix.cc
+++ b/ipc/chromium/src/base/time_posix.cc
@@ -5,17 +5,17 @@
 // found in the LICENSE file.
 
 #include "base/time.h"
 
 #ifdef OS_MACOSX
 #include <mach/mach_time.h>
 #endif
 #include <sys/time.h>
-#ifdef ANDROID
+#if defined(ANDROID) && !defined(__LP64__)
 #include <time64.h>
 #else
 #include <time.h>
 #endif
 #if defined(ANDROID) || defined(OS_POSIX)
 #include <unistd.h>
 #endif