Bug 1288590: Use GetAttrInfoAt in sdnAccessible.cpp draft
authorEmilio Cobos Álvarez <ecoal95@gmail.com>
Thu, 21 Jul 2016 20:12:00 -0700
changeset 391415 9e4c1e20d5acf14a69bde030e6bdcb3c50f779a3
parent 391405 8a7ae12f3c4295b7a3f2a686baf2314ad4438d00
child 391416 df158d5309fcbdc968be72194c4b99387e64aca7
push id23902
push userbmo:ealvarez@mozilla.com
push dateFri, 22 Jul 2016 18:21:53 +0000
bugs1288590
milestone50.0a1
Bug 1288590: Use GetAttrInfoAt in sdnAccessible.cpp MozReview-Commit-ID: LQrtUwssnQN
accessible/windows/sdn/sdnAccessible.cpp
--- a/accessible/windows/sdn/sdnAccessible.cpp
+++ b/accessible/windows/sdn/sdnAccessible.cpp
@@ -144,20 +144,21 @@ sdnAccessible::get_attributes(unsigned  
 
   *aNumAttribs = static_cast<unsigned short>(numAttribs);
 
   for (uint32_t index = 0; index < numAttribs; index++) {
     aNameSpaceIDs[index] = 0;
     aAttribValues[index] = aAttribNames[index] = nullptr;
     nsAutoString attributeValue;
 
-    const nsAttrName* name = elm->GetAttrNameAt(index);
-    aNameSpaceIDs[index] = static_cast<short>(name->NamespaceID());
-    aAttribNames[index] = ::SysAllocString(name->LocalName()->GetUTF16String());
-    elm->GetAttr(name->NamespaceID(), name->LocalName(), attributeValue);
+    nsAttrInfo attr = elm->GetAttrInfoAt(index);
+    attr.mValue->ToString(attributeValue);
+
+    aNameSpaceIDs[index] = static_cast<short>(attr.mName->NamespaceID());
+    aAttribNames[index] = ::SysAllocString(attr.mName->LocalName()->GetUTF16String());
     aAttribValues[index] = ::SysAllocString(attributeValue.get());
   }
 
   return S_OK;
 
   A11Y_TRYBLOCK_END
 }