Bug 1288219 - flip default assumptions for desktop-mode auto-invocation of touch keyboard, r?dolske draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Thu, 21 Jul 2016 17:07:07 +0100
changeset 390725 42e9891c20fab8fbd2cc74c359194fa8ecdf9f37
parent 390029 d224fc999cb6accb208af0a105f14433375e2e77
child 526052 04921c97fa4b28c347eb972b8de6e1a95c1bac51
push id23729
push usergijskruitbosch@gmail.com
push dateThu, 21 Jul 2016 16:07:31 +0000
reviewersdolske
bugs1288219
milestone50.0a1
Bug 1288219 - flip default assumptions for desktop-mode auto-invocation of touch keyboard, r?dolske MozReview-Commit-ID: E0LBQmGtsZE
widget/windows/WinIMEHandler.cpp
--- a/widget/windows/WinIMEHandler.cpp
+++ b/widget/windows/WinIMEHandler.cpp
@@ -843,30 +843,30 @@ IMEHandler::AutoInvokeOnScreenKeyboardIn
                            L"nsIWindowsRegKey not available");
     return false;
   }
   rv = regKey->Open(nsIWindowsRegKey::ROOT_KEY_CURRENT_USER,
                     NS_LITERAL_STRING("SOFTWARE\\Microsoft\\TabletTip\\1.7"),
                     nsIWindowsRegKey::ACCESS_QUERY_VALUE);
   if (NS_FAILED(rv)) {
     Preferences::SetString(kOskDebugReason,
-                           L"AIOSKIDM: failed opening regkey.");
-    return false;
+                           L"AIOSKIDM: failed opening regkey, assuming true.");
+    return true;
   }
   // EnableDesktopModeAutoInvoke is an opt-in option from the Windows
   // Settings to "Automatically show the touch keyboard in windowed apps
   // when there's no keyboard attached to your device." If the user has
   // opted-in to this behavior, the tablet-mode requirement is skipped.
   uint32_t value;
   rv = regKey->ReadIntValue(NS_LITERAL_STRING("EnableDesktopModeAutoInvoke"),
                             &value);
   if (NS_FAILED(rv)) {
     Preferences::SetString(kOskDebugReason,
                            L"AIOSKIDM: failed reading value of regkey.");
-    return false;
+    return true;
   }
   if (!!value) {
     Preferences::SetString(kOskDebugReason, L"AIOSKIDM: regkey value=true.");
   } else {
     Preferences::SetString(kOskDebugReason, L"AIOSKIDM: regkey value=false.");
   }
   return !!value;
 }