Bug 1285557 - Fix eslint errors on webbrowser devtools actor. r=jryans
MozReview-Commit-ID: 5TdmJHqqsn2
--- a/devtools/server/actors/webbrowser.js
+++ b/devtools/server/actors/webbrowser.js
@@ -1,16 +1,18 @@
/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
/* vim: set ft=javascript ts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
"use strict";
+/* global XPCNativeWrapper */
+
var { Ci, Cu } = require("chrome");
var Services = require("Services");
var { XPCOMUtils } = require("resource://gre/modules/XPCOMUtils.jsm");
var promise = require("promise");
var {
ActorPool, createExtraActors, appendExtraActors, GeneratedLocation
} = require("devtools/server/actors/common");
var { DebuggerServer } = require("devtools/server/main");
@@ -554,44 +556,46 @@ BrowserTabList.prototype._listenForEvent
* @param aShouldListen boolean
* True if we should add message listeners; false if we should remove them.
* @param aGuard string
* The name of a guard property of 'this', indicating whether we're
* already listening for those messages.
* @param aMessageNames array of strings
* An array of message names.
*/
-BrowserTabList.prototype._listenForMessagesIf = function (aShouldListen, aGuard, aMessageNames) {
- if (!aShouldListen !== !this[aGuard]) {
- let op = aShouldListen ? "addMessageListener" : "removeMessageListener";
- for (let win of allAppShellDOMWindows(DebuggerServer.chromeWindowType)) {
- for (let name of aMessageNames) {
- win.messageManager[op](name, this);
+BrowserTabList.prototype._listenForMessagesIf =
+ function (shouldListen, guard, messageNames) {
+ if (!shouldListen !== !this[guard]) {
+ let op = shouldListen ? "addMessageListener" : "removeMessageListener";
+ for (let win of allAppShellDOMWindows(DebuggerServer.chromeWindowType)) {
+ for (let name of messageNames) {
+ win.messageManager[op](name, this);
+ }
}
+ this[guard] = shouldListen;
}
- this[aGuard] = aShouldListen;
- }
-};
+ };
/**
* Implement nsIMessageListener.
*/
-BrowserTabList.prototype.receiveMessage = DevToolsUtils.makeInfallible(function (message) {
- let browser = message.target;
- switch (message.name) {
- case "DOMTitleChanged": {
- let actor = this._actorByBrowser.get(browser);
- if (actor) {
- this._notifyListChanged();
- this._checkListening();
+BrowserTabList.prototype.receiveMessage = DevToolsUtils.makeInfallible(
+ function (message) {
+ let browser = message.target;
+ switch (message.name) {
+ case "DOMTitleChanged": {
+ let actor = this._actorByBrowser.get(browser);
+ if (actor) {
+ this._notifyListChanged();
+ this._checkListening();
+ }
+ break;
}
- break;
}
- }
-});
+ });
/**
* Implement nsIDOMEventListener.
*/
BrowserTabList.prototype.handleEvent =
DevToolsUtils.makeInfallible(function (event) {
let browser = event.target.linkedBrowser;
switch (event.type) {
@@ -891,17 +895,19 @@ TabActor.prototype = {
traits: null,
// Optional console API listener options (e.g. used by the WebExtensionActor to
// filter console messages by addonID), set to an empty (no options) object by default.
consoleAPIListenerOptions: {},
// Optional TabSources filter function (e.g. used by the WebExtensionActor to filter
// sources by addonID), allow all sources by default.
- _allowSource() { return true; },
+ _allowSource() {
+ return true;
+ },
get exited() {
return this._exited;
},
get attached() {
return !!this._attached;
},
@@ -2042,17 +2048,17 @@ TabActor.prototype = {
* True if the window.console object is native, or false otherwise.
*/
hasNativeConsoleAPI(window) {
let isNative = false;
try {
// We are very explicitly examining the "console" property of
// the non-Xrayed object here.
let console = window.wrappedJSObject.console;
- isNative = new XPCNativeWrapper(console).IS_NATIVE_CONSOLE
+ isNative = new XPCNativeWrapper(console).IS_NATIVE_CONSOLE;
} catch (ex) {
// ignore
}
return isNative;
},
/**
* Create or return the StyleSheetActor for a style sheet. This method
@@ -2334,22 +2340,20 @@ BrowserAddonList.prototype._notifyListCh
}
};
BrowserAddonList.prototype._adjustListener = function () {
if (this._onListChanged) {
// As long as the callback exists, we need to listen for changes
// so we can notify about add-on changes.
AddonManager.addAddonListener(this);
- } else {
+ } else if (this._actorByAddonId.size === 0) {
// When the callback does not exist, we only need to keep listening
// if the actor cache will need adjusting when add-ons change.
- if (this._actorByAddonId.size === 0) {
- AddonManager.removeAddonListener(this);
- }
+ AddonManager.removeAddonListener(this);
}
};
exports.BrowserAddonList = BrowserAddonList;
/**
* The DebuggerProgressListener object is an nsIWebProgressListener which
* handles onStateChange events for the inspected browser. If the user tries to