Bug 1283282 - Make it more clear that MOZSCREENSHOTS_SETS is required for screenshots. r=aobreja draft
authorMatthew Noorenberghe <mozilla@noorenberghe.ca>
Tue, 19 Jul 2016 15:30:13 -0700
changeset 7031 15d16f0f8fb0b4b56b50cf10dd8251c79c142e9d
parent 7030 5c4cbb50084a8152c4106fa8483bbc9ed8e93b08
push id95
push usermozilla@noorenberghe.ca
push dateTue, 19 Jul 2016 22:30:55 +0000
reviewersaobreja
bugs1283282
Bug 1283282 - Make it more clear that MOZSCREENSHOTS_SETS is required for screenshots. r=aobreja MozReview-Commit-ID: 2zt8Vjry27w
trychooser/index.html
trychooser/trychooser.js
--- a/trychooser/index.html
+++ b/trychooser/index.html
@@ -260,17 +260,21 @@
                     <ul>OR
                     <li><label><input type="checkbox" value="mochitest-1">mochitest-1</label></li>
                     <li><label><input type="checkbox" value="mochitest-2">mochitest-2</label></li>
                     <li><label><input type="checkbox" value="mochitest-3">mochitest-3</label></li>
                     <li><label><input type="checkbox" value="mochitest-4">mochitest-4</label></li>
                     <li><label><input type="checkbox" value="mochitest-5">mochitest-5</label></li>
                     <li><label><input type="checkbox" value="mochitest-gl">mochitest-gl (webgl)</label></li>
                     <li><label><input type="checkbox" value="mochitest-bc">mochitest-bc (browser chrome)</label></li>
-                    <li><label><input type="checkbox" value="mochitest-browser-screenshots">mochitest-browser-screenshots</label></li>
+                    <li>
+                        <label id="mochitest-browser-screenshots" title="Requires the MOZSCREENSHOTS_SET environment variable to be specified">
+                            <input type="checkbox" value="mochitest-browser-screenshots">mochitest-browser-screenshots
+                        </label>
+                    </li>
                     <li><label><input type="checkbox" value="mochitest-dt">mochitest-dt (devtools)</label></li>
                     <li><label><input type="checkbox" value="mochitest-o">mochitest-o (other)</label></li>
                     <li><label><input type="checkbox" value="mochitest-media">mochitest-mda (dom/media)</label></li>
                     <li><label><input type="checkbox" value="mochitest-jetpack">mochitest-jetpack</label></li>
                     <li><label><input type="checkbox" value="mochitest-e10s-1">mochitest-e10s-1</label></li>
                     <li><label><input type="checkbox" value="mochitest-e10s-2">mochitest-e10s-2</label></li>
                     <li><label><input type="checkbox" value="mochitest-e10s-3">mochitest-e10s-3</label></li>
                     <li><label><input type="checkbox" value="mochitest-e10s-4">mochitest-e10s-4</label></li>
--- a/trychooser/trychooser.js
+++ b/trychooser/trychooser.js
@@ -243,19 +243,21 @@ function setresult() {
         $('#platforms-none').addClass('attention');
         incomplete = true;
     } else {
         $('#platforms-none').removeClass('attention');
     }
 
     if (value.match(/mochitest-browser-screenshots/) && !value.match(/MOZSCREENSHOTS_SETS=./)) {
         $('#setenv').addClass('attention');
+        $('#mochitest-browser-screenshots').addClass('attention');
         incomplete = true;
     } else {
         $('#setenv').removeClass('attention');
+        $('#mochitest-browser-screenshots').removeClass('attention');
     }
 
     if (incomplete) {
         value = "(NO JOBS CHOSEN)";
         $('.result').val(value);
     } else {
         $('#result_try').val('try: ' + value);
         $('#result_mach').val('./mach try ' + value);