--- a/layout/base/RestyleManager.cpp
+++ b/layout/base/RestyleManager.cpp
@@ -3259,35 +3259,35 @@ ElementRestyler::Restyle(nsRestyleHint a
// TEMPORARY (until bug 918064): Call RestyleSelf for each
// continuation or block-in-inline sibling.
// We must make a single decision on how to process this frame and
// its descendants, yet RestyleSelf might return different RestyleResult
// values for the different same-style continuations. |result| is our
// overall decision.
- RestyleResult result = eRestyleResult_None;
+ RestyleResult result = RestyleResult::eNone;
uint32_t swappedStructs = 0;
nsRestyleHint thisRestyleHint = aRestyleHint;
bool haveMoreContinuations = false;
for (nsIFrame* f = mFrame; f; ) {
RestyleResult thisResult =
RestyleSelf(f, thisRestyleHint, &swappedStructs, swaps);
- if (thisResult != eRestyleResult_Stop) {
+ if (thisResult != RestyleResult::eStop) {
// Calls to RestyleSelf for later same-style continuations must not
- // return eRestyleResult_Stop, so pass eRestyle_Force in to them.
+ // return RestyleResult::eStop, so pass eRestyle_Force in to them.
thisRestyleHint = nsRestyleHint(thisRestyleHint | eRestyle_Force);
- if (result == eRestyleResult_Stop) {
- // We received eRestyleResult_Stop for earlier same-style
- // continuations, and eRestyleResult_StopWithStyleChange or
- // eRestyleResult_Continue(AndForceDescendants) for this one; go
+ if (result == RestyleResult::eStop) {
+ // We received RestyleResult::eStop for earlier same-style
+ // continuations, and RestyleResult::eStopWithStyleChange or
+ // RestyleResult::eContinue(AndForceDescendants) for this one; go
// back and force-restyle the earlier continuations.
result = thisResult;
f = mFrame;
continue;
}
}
if (thisResult > result) {
@@ -3316,24 +3316,24 @@ ElementRestyler::Restyle(nsRestyleHint a
if (haveMoreContinuations && hintToRestore) {
// If we have more continuations with different style (e.g., because
// we're inside a ::first-letter or ::first-line), put the restyle
// hint back.
mRestyleTracker.AddPendingRestyleToTable(mContent->AsElement(),
hintToRestore, nsChangeHint(0));
}
- if (result == eRestyleResult_Stop) {
+ if (result == RestyleResult::eStop) {
MOZ_ASSERT(mFrame->StyleContext() == oldContext,
"frame should have been left with its old style context");
nsIFrame* unused;
nsStyleContext* newParent = mFrame->GetParentStyleContext(&unused);
if (oldContext->GetParent() != newParent) {
- // If we received eRestyleResult_Stop, then the old style context was
+ // If we received RestyleResult::eStop, then the old style context was
// left on mFrame. Since we ended up restyling our parent, change
// this old style context to point to its new parent.
LOG_RESTYLE("moving style context %p from old parent %p to new parent %p",
oldContext.get(), oldContext->GetParent(), newParent);
// We keep strong references to the new parent around until the end
// of the restyle, in case:
// (a) we swapped structs between the old and new parent,
// (b) some descendants of the old parent are not getting restyled
@@ -3358,24 +3358,24 @@ ElementRestyler::Restyle(nsRestyleHint a
mRestyleTracker.AddRestyleRootsIfAwaitingRestyle(descendants);
if (aRestyleHint & eRestyle_SomeDescendants) {
ConditionallyRestyleChildren();
}
return;
}
- if (result == eRestyleResult_StopWithStyleChange &&
+ if (result == RestyleResult::eStopWithStyleChange &&
!(mHintsHandled & nsChangeHint_ReconstructFrame)) {
MOZ_ASSERT(mFrame->StyleContext() != oldContext,
- "eRestyleResult_StopWithStyleChange should only be returned "
+ "RestyleResult::eStopWithStyleChange should only be returned "
"if we got a new style context or we will reconstruct");
MOZ_ASSERT(swappedStructs == 0,
"should have ensured we didn't swap structs when "
- "returning eRestyleResult_StopWithStyleChange");
+ "returning RestyleResult::eStopWithStyleChange");
// We need to ensure that all of the frames that inherit their style
// from oldContext are able to be moved across to newContext.
// MoveStyleContextsForChildren will check for certain conditions
// to ensure it is safe to move all of the relevant child style
// contexts to newContext. If these conditions fail, it will
// return false, and we'll have to continue restyling.
const bool canStop = MoveStyleContextsForChildren(oldContext);
@@ -3392,34 +3392,34 @@ ElementRestyler::Restyle(nsRestyleHint a
if (aRestyleHint & eRestyle_SomeDescendants) {
ConditionallyRestyleChildren();
}
return;
}
// Turns out we couldn't stop restyling here. Process the struct
// swaps that RestyleSelf would've done had we not returned
- // eRestyleResult_StopWithStyleChange.
+ // RestyleResult::eStopWithStyleChange.
for (SwapInstruction& swap : swaps) {
LOG_RESTYLE("swapping style structs between %p and %p",
swap.mOldContext.get(), swap.mNewContext.get());
swap.mOldContext->SwapStyleData(swap.mNewContext, swap.mStructsToSwap);
swappedStructs |= swap.mStructsToSwap;
}
swaps.Clear();
}
if (!swappedStructs) {
// If we swapped any structs from the old context, then we need to keep
// it alive until after the RestyleChildren call so that we can fix up
// its descendants' cached structs.
oldContext = nullptr;
}
- if (result == eRestyleResult_ContinueAndForceDescendants) {
+ if (result == RestyleResult::eContinueAndForceDescendants) {
childRestyleHint =
nsRestyleHint(childRestyleHint | eRestyle_ForceDescendants);
}
// No need to do this if we're planning to reframe already.
// It's also important to check mHintsHandled since we use
// mFrame->StyleContext(), which is out of date if mHintsHandled
// has a ReconstructFrame hint. Using an out of date style
@@ -3454,216 +3454,216 @@ ElementRestyler::Restyle(nsRestyleHint a
mRestyleTracker.AddRestyleRootsIfAwaitingRestyle(descendants);
}
/**
* Depending on the details of the frame we are restyling or its old style
* context, we may or may not be able to stop restyling after this frame if
* we find we had no style changes.
*
- * This function returns eRestyleResult_Stop if it does not find any
+ * This function returns RestyleResult::eStop if it does not find any
* conditions that would preclude stopping restyling, and
- * eRestyleResult_Continue if it does.
+ * RestyleResult::eContinue if it does.
*/
void
ElementRestyler::ComputeRestyleResultFromFrame(nsIFrame* aSelf,
RestyleResult& aRestyleResult,
bool& aCanStopWithStyleChange)
{
// We can't handle situations where the primary style context of a frame
// has not had any style data changes, but its additional style contexts
// have, so we don't considering stopping if this frame has any additional
// style contexts.
if (aSelf->GetAdditionalStyleContext(0)) {
LOG_RESTYLE_CONTINUE("there are additional style contexts");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
// Style changes might have moved children between the two nsLetterFrames
// (the one matching ::first-letter and the one containing the rest of the
// content). Continue restyling to the children of the nsLetterFrame so
// that they get the correct style context parent. Similarly for
// nsLineFrames.
nsIAtom* type = aSelf->GetType();
if (type == nsGkAtoms::letterFrame) {
LOG_RESTYLE_CONTINUE("frame is a letter frame");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
if (type == nsGkAtoms::lineFrame) {
LOG_RESTYLE_CONTINUE("frame is a line frame");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
// Some style computations depend not on the parent's style, but a grandparent
// or one the grandparent's ancestors. An example is an explicit 'inherit'
// value for align-self, where if the parent frame's value for the property is
// 'auto' we end up inheriting the computed value from the grandparent. We
// can't stop the restyling process on this frame (the one with 'auto', in
// this example), as the grandparent's computed value might have changed
// and we need to recompute the child's 'inherit' to that new value.
nsStyleContext* oldContext = aSelf->StyleContext();
if (oldContext->HasChildThatUsesGrandancestorStyle()) {
LOG_RESTYLE_CONTINUE("the old context uses grandancestor style");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
// We ignore all situations that involve :visited style.
if (oldContext->GetStyleIfVisited()) {
LOG_RESTYLE_CONTINUE("the old style context has StyleIfVisited");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
nsStyleContext* parentContext = oldContext->GetParent();
if (parentContext && parentContext->GetStyleIfVisited()) {
LOG_RESTYLE_CONTINUE("the old style context's parent has StyleIfVisited");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
// We also ignore frames for pseudos, as their style contexts have
// inheritance structures that do not match the frame inheritance
// structure. To avoid enumerating and checking all of the cases
// where we have this kind of inheritance, we keep restyling past
// pseudos.
nsIAtom* pseudoTag = oldContext->GetPseudo();
if (pseudoTag && !nsCSSAnonBoxes::IsNonElement(pseudoTag)) {
LOG_RESTYLE_CONTINUE("the old style context is for a pseudo");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
nsIFrame* parent = mFrame->GetParent();
if (parent) {
// Also if the parent has a pseudo, as this frame's style context will
// be inheriting from a grandparent frame's style context (or a further
// ancestor).
nsIAtom* parentPseudoTag = parent->StyleContext()->GetPseudo();
if (parentPseudoTag &&
parentPseudoTag != nsCSSAnonBoxes::mozOtherNonElement) {
MOZ_ASSERT(parentPseudoTag != nsCSSAnonBoxes::mozText,
"Style of text node should not be parent of anything");
LOG_RESTYLE_CONTINUE("the old style context's parent is for a pseudo");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
// Parent style context pseudo-ness doesn't affect whether we can
- // return eRestyleResult_StopWithStyleChange.
+ // return RestyleResult::eStopWithStyleChange.
//
// If we had later conditions to check in this function, we would
// continue to check them, in case we set aCanStopWithStyleChange to
// false.
}
}
}
void
ElementRestyler::ComputeRestyleResultFromNewContext(nsIFrame* aSelf,
nsStyleContext* aNewContext,
RestyleResult& aRestyleResult,
bool& aCanStopWithStyleChange)
{
// If we've already determined that we must continue styling, we don't
// need to check anything.
- if (aRestyleResult == eRestyleResult_Continue && !aCanStopWithStyleChange) {
+ if (aRestyleResult == RestyleResult::eContinue && !aCanStopWithStyleChange) {
return;
}
// Keep restyling if the new style context has any style-if-visted style, so
// that we can avoid the style context tree surgery having to deal to deal
// with visited styles.
if (aNewContext->GetStyleIfVisited()) {
LOG_RESTYLE_CONTINUE("the new style context has StyleIfVisited");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
// If link-related information has changed, or the pseudo for the frame has
// changed, or the new style context points to a different rule node, we can't
// leave the old style context on the frame.
nsStyleContext* oldContext = aSelf->StyleContext();
if (oldContext->IsLinkContext() != aNewContext->IsLinkContext() ||
oldContext->RelevantLinkVisited() != aNewContext->RelevantLinkVisited() ||
oldContext->GetPseudo() != aNewContext->GetPseudo() ||
oldContext->GetPseudoType() != aNewContext->GetPseudoType()) {
LOG_RESTYLE_CONTINUE("the old and new style contexts have different link/"
"visited/pseudo");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
if (oldContext->RuleNode() != aNewContext->RuleNode()) {
LOG_RESTYLE_CONTINUE("the old and new style contexts have different "
"rulenodes");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
// Continue to check other conditions if aCanStopWithStyleChange might
// still need to be set to false.
if (!aCanStopWithStyleChange) {
return;
}
}
// If the old and new style contexts differ in their
// NS_STYLE_HAS_TEXT_DECORATION_LINES or NS_STYLE_HAS_PSEUDO_ELEMENT_DATA
// bits, then we must keep restyling so that those new bit values are
// propagated.
if (oldContext->HasTextDecorationLines() !=
aNewContext->HasTextDecorationLines()) {
LOG_RESTYLE_CONTINUE("NS_STYLE_HAS_TEXT_DECORATION_LINES differs between old"
" and new style contexts");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
if (oldContext->HasPseudoElementData() !=
aNewContext->HasPseudoElementData()) {
LOG_RESTYLE_CONTINUE("NS_STYLE_HAS_PSEUDO_ELEMENT_DATA differs between old"
" and new style contexts");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
if (oldContext->ShouldSuppressLineBreak() !=
aNewContext->ShouldSuppressLineBreak()) {
LOG_RESTYLE_CONTINUE("NS_STYLE_SUPPRESS_LINEBREAK differs"
"between old and new style contexts");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
if (oldContext->IsInDisplayNoneSubtree() !=
aNewContext->IsInDisplayNoneSubtree()) {
LOG_RESTYLE_CONTINUE("NS_STYLE_IN_DISPLAY_NONE_SUBTREE differs between old"
" and new style contexts");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
if (oldContext->IsTextCombined() != aNewContext->IsTextCombined()) {
LOG_RESTYLE_CONTINUE("NS_STYLE_IS_TEXT_COMBINED differs between "
"old and new style contexts");
- aRestyleResult = eRestyleResult_Continue;
+ aRestyleResult = RestyleResult::eContinue;
aCanStopWithStyleChange = false;
return;
}
}
bool
ElementRestyler::SelectorMatchesForRestyle(Element* aElement)
{
@@ -3805,41 +3805,41 @@ ElementRestyler::RestyleSelf(nsIFrame* a
LOG_RESTYLE("RestyleSelf %s, aRestyleHint = %s",
FrameTagToString(aSelf).get(),
RestyleManager::RestyleHintToString(aRestyleHint).get());
LOG_RESTYLE_INDENT();
// Initially assume that it is safe to stop restyling.
//
// Throughout most of this function, we update the following two variables
- // independently. |result| is set to eRestyleResult_Continue when we
- // detect a condition that would not allow us to return eRestyleResult_Stop.
+ // independently. |result| is set to RestyleResult::eContinue when we
+ // detect a condition that would not allow us to return RestyleResult::eStop.
// |canStopWithStyleChange| is set to false when we detect a condition
- // that would not allow us to return eRestyleResult_StopWithStyleChange.
+ // that would not allow us to return RestyleResult::eStopWithStyleChange.
//
// Towards the end of this function, we reconcile these two variables --
// if |canStopWithStyleChange| is true, we convert |result| into
- // eRestyleResult_StopWithStyleChange.
- RestyleResult result = eRestyleResult_Stop;
+ // RestyleResult::eStopWithStyleChange.
+ RestyleResult result = RestyleResult::eStop;
bool canStopWithStyleChange = true;
if (aRestyleHint & ~eRestyle_SomeDescendants) {
// If we are doing any restyling of the current element, or if we're
// forced to continue, we must.
- result = eRestyleResult_Continue;
+ result = RestyleResult::eContinue;
// If we have to restyle children, we can't return
- // eRestyleResult_StopWithStyleChange.
+ // RestyleResult::eStopWithStyleChange.
if (aRestyleHint & (eRestyle_Subtree | eRestyle_Force |
eRestyle_ForceDescendants)) {
canStopWithStyleChange = false;
}
}
- // We only consider returning eRestyleResult_StopWithStyleChange if this
+ // We only consider returning RestyleResult::eStopWithStyleChange if this
// is the root of the restyle. (Otherwise, we would need to track the
// style changes of the ancestors we just restyled.)
if (!mIsRootOfRestyle) {
canStopWithStyleChange = false;
}
// Look at the frame and its current style context for conditions
// that would change our RestyleResult.
@@ -3886,17 +3886,17 @@ ElementRestyler::RestyleSelf(nsIFrame* a
// The provider's new context becomes the parent context of
// aSelf's context.
parentContext = providerFrame->StyleContext();
// Set |mResolvedChild| so we don't bother resolving the
// provider again.
mResolvedChild = providerFrame;
LOG_RESTYLE_CONTINUE("we had a provider frame");
// Continue restyling past the odd style context inheritance.
- result = eRestyleResult_Continue;
+ result = RestyleResult::eContinue;
canStopWithStyleChange = false;
}
if (providerFrame != aSelf->GetParent()) {
// We don't actually know what the parent style context's
// non-inherited hints were, so assume the worst.
mParentFrameHintsNotHandledForDescendants =
nsChangeHint_Hints_NotHandledForDescendants;
@@ -4020,51 +4020,51 @@ ElementRestyler::RestyleSelf(nsIFrame* a
oldContext->RelevantLinkVisited() ==
newContext->RelevantLinkVisited()) {
// We're the root of the style context tree and the new style
// context returned has the same rule node. This means that
// we can use FindChildWithRules to keep a lot of the old
// style contexts around. However, we need to start from the
// same root.
LOG_RESTYLE("restyling root and keeping old context");
- LOG_RESTYLE_IF(this, result != eRestyleResult_Continue,
+ LOG_RESTYLE_IF(this, result != RestyleResult::eContinue,
"continuing restyle since this is the root");
newContext = oldContext;
// Never consider stopping restyling at the root.
- result = eRestyleResult_Continue;
+ result = RestyleResult::eContinue;
canStopWithStyleChange = false;
}
}
LOG_RESTYLE("oldContext = %p, newContext = %p%s",
oldContext.get(), newContext.get(),
oldContext == newContext ? (const char*) " (same)" :
(const char*) "");
if (newContext != oldContext) {
if (oldContext->IsShared()) {
// If the old style context was shared, then we can't return
- // eRestyleResult_Stop and patch its parent to point to the
+ // RestyleResult::eStop and patch its parent to point to the
// new parent style context, as that change might not be valid
// for the other frames sharing the style context.
LOG_RESTYLE_CONTINUE("the old style context is shared");
- result = eRestyleResult_Continue;
-
- // It is not safe to return eRestyleResult_StopWithStyleChange
+ result = RestyleResult::eContinue;
+
+ // It is not safe to return RestyleResult::eStopWithStyleChange
// when oldContext is shared and newContext has different
// inherited style data, regardless of whether the oldContext has
// that inherited style data cached. We can't simply rely on the
// samePointerStructs check later on, as the descendent style
// contexts just might not have had their inherited style data
// requested yet (which is possible for example if we flush style
// between resolving an initial style context for a frame and
// building its display list items). Therefore we must compare
// the rule nodes of oldContext and newContext to see if the
// restyle results in new inherited style data. If not, then
- // we can continue assuming that eRestyleResult_StopWithStyleChange
+ // we can continue assuming that RestyleResult::eStopWithStyleChange
// is safe. Without this check, we could end up with style contexts
// shared between elements which should have different styles.
if (!CommonInheritedStyleData(oldContext->RuleNode(),
newContext->RuleNode())) {
canStopWithStyleChange = false;
}
}
@@ -4078,71 +4078,71 @@ ElementRestyler::RestyleSelf(nsIFrame* a
uint32_t samePointerStructs = 0;
if (copyFromContinuation) {
// In theory we should know whether there was any style data difference,
// since we would have calculated that in the previous call to
// RestyleSelf, so until we perform only one restyling per chain-of-
// same-style continuations (bug 918064), we need to check again here to
// determine whether it is safe to stop restyling.
- if (result == eRestyleResult_Stop) {
+ if (result == RestyleResult::eStop) {
oldContext->CalcStyleDifference(newContext, nsChangeHint(0),
&equalStructs,
&samePointerStructs);
if (equalStructs != NS_STYLE_INHERIT_MASK) {
// At least one struct had different data in it, so we must
// continue restyling children.
LOG_RESTYLE_CONTINUE("there is different style data: %s",
RestyleManager::StructNamesToString(
~equalStructs & NS_STYLE_INHERIT_MASK).get());
- result = eRestyleResult_Continue;
+ result = RestyleResult::eContinue;
}
}
} else {
bool changedStyle =
RestyleManager::TryStartingTransition(mPresContext, aSelf->GetContent(),
oldContext, &newContext);
if (changedStyle) {
LOG_RESTYLE_CONTINUE("TryStartingTransition changed the new style context");
- result = eRestyleResult_Continue;
+ result = RestyleResult::eContinue;
canStopWithStyleChange = false;
}
CaptureChange(oldContext, newContext, assumeDifferenceHint,
&equalStructs, &samePointerStructs);
if (equalStructs != NS_STYLE_INHERIT_MASK) {
// At least one struct had different data in it, so we must
// continue restyling children.
LOG_RESTYLE_CONTINUE("there is different style data: %s",
RestyleManager::StructNamesToString(
~equalStructs & NS_STYLE_INHERIT_MASK).get());
- result = eRestyleResult_Continue;
+ result = RestyleResult::eContinue;
}
}
if (canStopWithStyleChange) {
// If any inherited struct pointers are different, or if any
// reset struct pointers are different and we have descendants
// that rely on those reset struct pointers, we can't return
- // eRestyleResult_StopWithStyleChange.
+ // RestyleResult::eStopWithStyleChange.
if ((samePointerStructs & NS_STYLE_INHERITED_STRUCT_MASK) !=
NS_STYLE_INHERITED_STRUCT_MASK) {
- LOG_RESTYLE("can't return eRestyleResult_StopWithStyleChange since "
+ LOG_RESTYLE("can't return RestyleResult::eStopWithStyleChange since "
"there is different inherited data");
canStopWithStyleChange = false;
} else if ((samePointerStructs & NS_STYLE_RESET_STRUCT_MASK) !=
NS_STYLE_RESET_STRUCT_MASK &&
oldContext->HasChildThatUsesResetStyle()) {
- LOG_RESTYLE("can't return eRestyleResult_StopWithStyleChange since "
+ LOG_RESTYLE("can't return RestyleResult::eStopWithStyleChange since "
"there is different reset data and descendants use it");
canStopWithStyleChange = false;
}
}
- if (result == eRestyleResult_Stop) {
- // Since we currently have eRestyleResult_Stop, we know at this
+ if (result == RestyleResult::eStop) {
+ // Since we currently have RestyleResult::eStop, we know at this
// point that all of our style structs are equal in terms of styles.
// However, some of them might be different pointers. Since our
// descendants might share those pointers, we have to continue to
// restyling our descendants.
//
// However, because of the swapping of equal structs we've done on
// ancestors (later in this function), we've ensured that for structs
// that cannot be stored in the rule tree, we keep the old equal structs
@@ -4159,63 +4159,63 @@ ElementRestyler::RestyleSelf(nsIFrame* a
// FIXME This loop could be rewritten as bit operations on
// oldContext->mBits and samePointerStructs.
for (nsStyleStructID sid = nsStyleStructID(0);
sid < nsStyleStructID_Length;
sid = nsStyleStructID(sid + 1)) {
if (oldContext->HasCachedDependentStyleData(sid) &&
!(samePointerStructs & nsCachedStyleData::GetBitForSID(sid))) {
LOG_RESTYLE_CONTINUE("there are different struct pointers");
- result = eRestyleResult_Continue;
+ result = RestyleResult::eContinue;
break;
}
}
}
// From this point we no longer do any assignments of
- // eRestyleResult_Continue to |result|. If canStopWithStyleChange is true,
+ // RestyleResult::eContinue to |result|. If canStopWithStyleChange is true,
// it means that we can convert |result| (whether it is
- // eRestyleResult_Continue or eRestyleResult_Stop) into
- // eRestyleResult_StopWithStyleChange.
+ // RestyleResult::eContinue or RestyleResult::eStop) into
+ // RestyleResult::eStopWithStyleChange.
if (canStopWithStyleChange) {
- LOG_RESTYLE("converting %s into eRestyleResult_StopWithStyleChange",
+ LOG_RESTYLE("converting %s into RestyleResult::eStopWithStyleChange",
RestyleResultToString(result).get());
- result = eRestyleResult_StopWithStyleChange;
+ result = RestyleResult::eStopWithStyleChange;
}
if (aRestyleHint & eRestyle_ForceDescendants) {
- result = eRestyleResult_ContinueAndForceDescendants;
+ result = RestyleResult::eContinueAndForceDescendants;
}
if (!(mHintsHandled & nsChangeHint_ReconstructFrame)) {
// If the frame gets regenerated, let it keep its old context,
// which is important to maintain various invariants about
// frame types matching their style contexts.
// Note that this check even makes sense if we didn't call
// CaptureChange because of copyFromContinuation being true,
// since we'll have copied the existing context from the
// previous continuation, so newContext == oldContext.
- if (result != eRestyleResult_Stop) {
+ if (result != RestyleResult::eStop) {
if (copyFromContinuation) {
LOG_RESTYLE("not swapping style structs, since we copied from a "
"continuation");
} else if (oldContext->IsShared() && newContext->IsShared()) {
LOG_RESTYLE("not swapping style structs, since both old and contexts "
"are shared");
} else if (oldContext->IsShared()) {
LOG_RESTYLE("not swapping style structs, since the old context is "
"shared");
} else if (newContext->IsShared()) {
LOG_RESTYLE("not swapping style structs, since the new context is "
"shared");
} else {
- if (result == eRestyleResult_StopWithStyleChange) {
+ if (result == RestyleResult::eStopWithStyleChange) {
LOG_RESTYLE("recording a style struct swap between %p and %p to "
- "do if eRestyleResult_StopWithStyleChange fails",
+ "do if RestyleResult::eStopWithStyleChange fails",
oldContext.get(), newContext.get());
SwapInstruction* swap = aSwaps.AppendElement();
swap->mOldContext = oldContext;
swap->mNewContext = newContext;
swap->mStructsToSwap = equalStructs;
} else {
LOG_RESTYLE("swapping style structs between %p and %p",
oldContext.get(), newContext.get());
@@ -4245,17 +4245,17 @@ ElementRestyler::RestyleSelf(nsIFrame* a
// mSwappedStructOwners.
//
// We really only need to do this if we did swap structs on the
// parent, but we don't have that information here.
mSwappedStructOwners.AppendElement(newContext->GetParent());
}
} else {
if (aRestyleHint & eRestyle_ForceDescendants) {
- result = eRestyleResult_ContinueAndForceDescendants;
+ result = RestyleResult::eContinueAndForceDescendants;
}
}
oldContext = nullptr;
// do additional contexts
// XXXbz might be able to avoid selector matching here in some
// cases; won't worry about it for now.
int32_t contextIndex = 0;
@@ -4497,17 +4497,17 @@ ElementRestyler::ComputeStyleChangeFor(n
aRestyleHintData.mSelectorsForDescendants);
nsTArray<nsIContent*> visibleKidsOfHiddenElement;
nsIFrame* nextIBSibling;
for (nsIFrame* ibSibling = aFrame; ibSibling; ibSibling = nextIBSibling) {
nextIBSibling = GetNextBlockInInlineSibling(propTable, ibSibling);
if (nextIBSibling) {
// Don't allow some ib-split siblings to be processed with
- // eRestyleResult_StopWithStyleChange and others not.
+ // RestyleResult::eStopWithStyleChange and others not.
aRestyleHint |= eRestyle_Force;
}
// Outer loop over ib-split siblings
for (nsIFrame* cont = ibSibling; cont; cont = cont->GetNextContinuation()) {
if (GetPrevContinuationWithSameStyle(cont)) {
// We already handled this element when dealing with its earlier
// continuation.
@@ -5176,29 +5176,29 @@ RestyleManager::StructNamesToString(uint
return result;
}
/* static */ nsCString
ElementRestyler::RestyleResultToString(RestyleResult aRestyleResult)
{
nsCString result;
switch (aRestyleResult) {
- case eRestyleResult_Stop:
- result.AssignLiteral("eRestyleResult_Stop");
+ case RestyleResult::eStop:
+ result.AssignLiteral("RestyleResult::eStop");
break;
- case eRestyleResult_StopWithStyleChange:
- result.AssignLiteral("eRestyleResult_StopWithStyleChange");
+ case RestyleResult::eStopWithStyleChange:
+ result.AssignLiteral("RestyleResult::eStopWithStyleChange");
break;
- case eRestyleResult_Continue:
- result.AssignLiteral("eRestyleResult_Continue");
+ case RestyleResult::eContinue:
+ result.AssignLiteral("RestyleResult::eContinue");
break;
- case eRestyleResult_ContinueAndForceDescendants:
- result.AssignLiteral("eRestyleResult_ContinueAndForceDescendants");
+ case RestyleResult::eContinueAndForceDescendants:
+ result.AssignLiteral("RestyleResult::eContinueAndForceDescendants");
break;
default:
- MOZ_ASSERT(aRestyleResult == eRestyleResult_None,
+ MOZ_ASSERT(aRestyleResult == RestyleResult::eNone,
"Unexpected RestyleResult");
}
return result;
}
#endif
} // namespace mozilla