mozreview: add testing for diffstats on drafts (
Bug 1286017). r?glob
MozReview-Commit-ID: Ffdi9Xjf5Y6
--- a/hgext/reviewboard/tests/test-review-request-summary.t
+++ b/hgext/reviewboard/tests/test-review-request-summary.t
@@ -297,12 +297,134 @@ Verify we can also get the summaries by
delete: 1
insert: 1
Verify that we get nothing from non-existent bugs.
$ rbmanage dump-summaries-by-bug 2
[]
+Create a draft with different diffstats
+
+ $ echo "more foo" >> foo
+ $ echo "and even more" >> foo
+ $ hg commit --amend
+ saved backup bundle to $TESTTMP/client/.hg/strip-backup/*-amend-backup.hg (glob)
+ $ hg push --config reviewboard.autopublish=false
+ pushing to ssh://$DOCKER_HOSTNAME:$HGPORT6/test-repo
+ searching for changes
+ remote: adding changesets
+ remote: adding manifests
+ remote: adding file changes
+ remote: added 1 changesets with 1 changes to 1 files (+1 heads)
+ remote: recorded push in pushlog
+ submitting 2 changesets for review
+
+ changeset: 1:98467d80785e
+ summary: Bug 1 - Foo 1
+ review: http://$DOCKER_HOSTNAME:$HGPORT1/r/2
+
+ changeset: 2:5db0083a9399
+ summary: Bug 1 - Foo 2
+ review: http://$DOCKER_HOSTNAME:$HGPORT1/r/3 (draft)
+
+ review id: bz://1/mynick
+ review url: http://$DOCKER_HOSTNAME:$HGPORT1/r/1 (draft)
+
+ (review requests lack reviewers; visit review url to assign reviewers)
+ (visit review url to publish these review requests so others can see them)
+
+Verify that requesting the summary as the submitter will show draft diffstats
+
+ $ exportbzauth default@example.com password
+ $ rbmanage dump-summary 1
+ parent:
+ summary: bz://1/mynick
+ id: 1
+ submitter: default+5
+ issue_open_count: 0
+ status: pending
+ has_draft: true
+ reviewers:
+ - reviewer
+ diff:
+ delete: 1
+ insert: 3
+ children:
+ - summary: Bug 1 - Foo 1
+ id: 2
+ commit: 98467d80785ec84dd871f213c167ed704a6d974d
+ submitter: default+5
+ issue_open_count: 0
+ status: submitted
+ has_draft: false
+ reviewers:
+ - reviewer
+ reviewers_status:
+ reviewer:
+ review_flag: r+
+ ship_it: true
+ diff:
+ delete: 1
+ insert: 1
+ - summary: Bug 1 - Foo 2
+ id: 3
+ commit: 3a446ae4382006c43cdfa5aa33c494f582736f35
+ submitter: default+5
+ issue_open_count: 0
+ status: pending
+ has_draft: true
+ reviewers: []
+ reviewers_status: {}
+ diff:
+ delete: 1
+ insert: 3
+
+Verify non-submitters will not see the draft diffstats
+
+ $ exportbzauth reviewer@example.com password1
+ $ rbmanage dump-summary 1
+ parent:
+ summary: bz://1/mynick
+ id: 1
+ submitter: default+5
+ issue_open_count: 0
+ status: pending
+ has_draft: true
+ reviewers:
+ - reviewer
+ diff:
+ delete: 1
+ insert: 1
+ children:
+ - summary: Bug 1 - Foo 1
+ id: 2
+ commit: 98467d80785ec84dd871f213c167ed704a6d974d
+ submitter: default+5
+ issue_open_count: 0
+ status: submitted
+ has_draft: false
+ reviewers:
+ - reviewer
+ reviewers_status:
+ reviewer:
+ review_flag: r+
+ ship_it: true
+ diff:
+ delete: 1
+ insert: 1
+ - summary: Bug 1 - Foo 2
+ id: 3
+ commit: 3a446ae4382006c43cdfa5aa33c494f582736f35
+ submitter: default+5
+ issue_open_count: 0
+ status: pending
+ has_draft: true
+ reviewers: []
+ reviewers_status: {}
+ diff:
+ delete: 1
+ insert: 1
+
Cleanup
$ mozreview stop
stopped 9 containers