Bug 1279005 - Drop is_filepath method argument draft
authorNelson João Morais <njmorais@gmail.com>
Fri, 15 Jul 2016 00:01:38 +0100
changeset 387852 a285eea98c5651e4fe1db0b928264a420aa466b2
parent 387565 f703544357243f2c49fa4d3ef6039269fbb2ff69
child 525466 94cabde8a2205f22e39b622cb6465b7d1e629108
push id23087
push userbmo:njmorais@gmail.com
push dateThu, 14 Jul 2016 23:01:55 +0000
bugs1279005
milestone50.0a1
Bug 1279005 - Drop is_filepath method argument MozReview-Commit-ID: B9aIR4sDipF
testing/marionette/harness/marionette/runner/base.py
--- a/testing/marionette/harness/marionette/runner/base.py
+++ b/testing/marionette/harness/marionette/runner/base.py
@@ -826,26 +826,25 @@ setReq.onerror = function() {
             else:
                 self.marionette.baseurl = self.server_root
                 self.logger.info("using remote content from %s" % self.marionette.baseurl)
 
     def _add_tests(self, tests):
         for test in tests:
             self.add_test(test)
 
-        invalid_tests = [t['filepath'] for t in self.tests if not self._is_filename_valid(t['filepath'], True)]
+        invalid_tests = [t['filepath'] for t in self.tests if not self._is_filename_valid(t['filepath'])]
         if invalid_tests:
             raise Exception("Test file names must be of the form "
                             "'test_something.py', 'test_something.js', or 'testSomething.js'."
                             " Invalid test names:\n  %s"
                             % '\n  '.join(invalid_tests))
 
-    def _is_filename_valid(self, filename, is_filepath=False):
-        if is_filepath:
-            filename = os.path.basename(filename)
+    def _is_filename_valid(self, filename):
+        filename = os.path.basename(filename)
         return self.filename_pattern.match(filename)
 
     def _log_skipped_tests(self):
         for test in self.manifest_skipped_tests:
             name = os.path.basename(test['path'])
             self.logger.test_start(name)
             self.logger.test_end(name,
                                  'SKIP',