pushlog: fix static analysis warnings; r=glandium
authorGregory Szorc <gps@mozilla.com>
Thu, 14 Jul 2016 10:30:35 -0700
changeset 8960 c899050702ff9ff4b8cf052e2bd185ee49a38fa6
parent 8959 62aae13f736e626fa28c3f825f795570fbf3a8fc
child 8961 5d87802927e17c50695963c12d48a0db64a384ae
push id1034
push userbmo:gps@mozilla.com
push dateTue, 19 Jul 2016 18:10:24 +0000
reviewersglandium
pushlog: fix static analysis warnings; r=glandium Dropped some unused variables. Fixed some whitespace. The entire file is now clean. MozReview-Commit-ID: LJoDWFwMNBz
hgext/pushlog-legacy/pushlog-feed.py
--- a/hgext/pushlog-legacy/pushlog-feed.py
+++ b/hgext/pushlog-legacy/pushlog-feed.py
@@ -383,33 +383,31 @@ def pushlogHTML(web, req, tmpl):
         numpages = int(ceil(query.totalentries / float(PUSHES_PER_PAGE)))
         start = max(1, query.page - PUSHES_PER_PAGE/2)
         end = min(numpages + 1, query.page + PUSHES_PER_PAGE/2)
         if query.page != 1:
             nav.append({'page': 1, 'label': "First"})
             nav.append({'page': query.page - 1, 'label': "Prev"})
         for i in range(start, end):
             nav.append({'page': i, 'label': str(i)})
-        
+
         if query.page != numpages:
             nav.append({'page': query.page + 1, 'label': "Next"})
             nav.append({'page': numpages, 'label': "Last"})
         return nav
 
     def changelist(limit=0, **map):
         # useless fallback
         listfilediffs = lambda a,b,c: []
         if hasattr(webutil, 'listfilediffs'):
             listfilediffs = lambda a,b,c: webutil.listfilediffs(a,b,c, len(b))
         elif hasattr(web, 'listfilediffs'):
             listfilediffs = web.listfilediffs
 
-        allentries = []
         lastid = None
-        ch = None
         l = []
         mergehidden = ""
         p = 0
         currentpush = None
         for id, user, date, node in query.entries:
             if isinstance(node, unicode):
                 node = node.encode('utf-8')
             ctx = web.repo.changectx(node)