Bug 1286444 - Store uint32_t's in VideoPlaybackQuality - r=kinetik
Because VideoPlaybackQuality attributes are exposed as 'unsigned long' (aka
uint32_t) in the webidl interface, it would be dangerous to accept and store
them as uint64_t in the class.
MozReview-Commit-ID: EhX4lhTbA3c
--- a/dom/media/VideoPlaybackQuality.cpp
+++ b/dom/media/VideoPlaybackQuality.cpp
@@ -11,19 +11,19 @@
#include "nsCycleCollectionParticipant.h"
#include "nsWrapperCache.h"
namespace mozilla {
namespace dom {
VideoPlaybackQuality::VideoPlaybackQuality(HTMLMediaElement* aElement,
DOMHighResTimeStamp aCreationTime,
- uint64_t aTotalFrames,
- uint64_t aDroppedFrames,
- uint64_t aCorruptedFrames)
+ uint32_t aTotalFrames,
+ uint32_t aDroppedFrames,
+ uint32_t aCorruptedFrames)
: mElement(aElement)
, mCreationTime(aCreationTime)
, mTotalFrames(aTotalFrames)
, mDroppedFrames(aDroppedFrames)
, mCorruptedFrames(aCorruptedFrames)
{
}
--- a/dom/media/VideoPlaybackQuality.h
+++ b/dom/media/VideoPlaybackQuality.h
@@ -16,50 +16,52 @@ namespace mozilla {
namespace dom {
class VideoPlaybackQuality final : public nsWrapperCache
{
public:
NS_INLINE_DECL_CYCLE_COLLECTING_NATIVE_REFCOUNTING(VideoPlaybackQuality)
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_NATIVE_CLASS(VideoPlaybackQuality)
- VideoPlaybackQuality(HTMLMediaElement* aElement, DOMHighResTimeStamp aCreationTime,
- uint64_t aTotalFrames, uint64_t aDroppedFrames,
- uint64_t aCorruptedFrames);
+ VideoPlaybackQuality(HTMLMediaElement* aElement,
+ DOMHighResTimeStamp aCreationTime,
+ uint32_t aTotalFrames,
+ uint32_t aDroppedFrames,
+ uint32_t aCorruptedFrames);
HTMLMediaElement* GetParentObject() const;
JSObject* WrapObject(JSContext* aCx, JS::Handle<JSObject*> aGivenProto) override;
DOMHighResTimeStamp CreationTime() const
{
return mCreationTime;
}
- uint64_t TotalVideoFrames()
+ uint32_t TotalVideoFrames()
{
return mTotalFrames;
}
- uint64_t DroppedVideoFrames()
+ uint32_t DroppedVideoFrames()
{
return mDroppedFrames;
}
- uint64_t CorruptedVideoFrames()
+ uint32_t CorruptedVideoFrames()
{
return mCorruptedFrames;
}
private:
~VideoPlaybackQuality() {}
RefPtr<HTMLMediaElement> mElement;
DOMHighResTimeStamp mCreationTime;
- uint64_t mTotalFrames;
- uint64_t mDroppedFrames;
- uint64_t mCorruptedFrames;
+ uint32_t mTotalFrames;
+ uint32_t mDroppedFrames;
+ uint32_t mCorruptedFrames;
};
} // namespace dom
} // namespace mozilla
#endif /* mozilla_dom_VideoPlaybackQuality_h_ */