Bug 1286444 - Use 64-bit numbers for VideoPlaybackQuality bindings - r?bz draft
authorGerald Squelart <gsquelart@mozilla.com>
Wed, 13 Jul 2016 14:36:27 +1000
changeset 386977 ddac94e6fe3b5161cd3a99be001cb9c9b4d6f85b
parent 386892 53947432322b06f80b079fef73e43d7e6785f81b
child 525264 321a45402d4ae564f7b877e3c02c33ccb3ccc097
push id22868
push usergsquelart@mozilla.com
push dateWed, 13 Jul 2016 04:40:11 +0000
reviewersbz
bugs1286444
milestone50.0a1
Bug 1286444 - Use 64-bit numbers for VideoPlaybackQuality bindings - r?bz totalVideoFrames, droppedVideoFrames, and corruptedVideoFrames were 'unsigned long' (equivalent to uint32_t), but they come from the VideoPlaybackQuality class, which stores and exposes uint64_t numbers. So to avoid silent truncation, these attributes should use unsigned long long (equivalent to uint64_t) instead. MozReview-Commit-ID: ECgA5iLPRXO
dom/webidl/VideoPlaybackQuality.webidl
--- a/dom/webidl/VideoPlaybackQuality.webidl
+++ b/dom/webidl/VideoPlaybackQuality.webidl
@@ -8,14 +8,14 @@
  *
  * Copyright © 2012 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C
  * liability, trademark and document use rules apply.
  */
 
 [Func="mozilla::dom::MediaSource::Enabled"]
 interface VideoPlaybackQuality {
   readonly attribute DOMHighResTimeStamp creationTime;
-  readonly attribute unsigned long totalVideoFrames;
-  readonly attribute unsigned long droppedVideoFrames;
-  readonly attribute unsigned long corruptedVideoFrames;
+  readonly attribute unsigned long long totalVideoFrames;
+  readonly attribute unsigned long long droppedVideoFrames;
+  readonly attribute unsigned long long corruptedVideoFrames;
 // At Risk: readonly attribute double totalFrameDelay;
 };