Bug 1058438 - Add additional tests for disabledHost APIs in desktop with nonascii characters in URLs. r=MattN draft
authorSaad Quadri <saad@saadquadri.com>
Tue, 12 Jul 2016 14:57:34 -0700
changeset 386848 2aea4bd6c346195b737e37bd7e303c39c19ebccd
parent 386847 147ce7b518177076e019fab349a27e59fddcb3f8
child 386849 fe21d67b29e786c077b66ea873cf4c106278b58a
push id22825
push usersaad@saadquadri.com
push dateTue, 12 Jul 2016 21:59:20 +0000
reviewersMattN
bugs1058438
milestone50.0a1
Bug 1058438 - Add additional tests for disabledHost APIs in desktop with nonascii characters in URLs. r=MattN MozReview-Commit-ID: EsN6FNCzbLk
toolkit/components/passwordmgr/test/unit/test_disabled_hosts.js
--- a/toolkit/components/passwordmgr/test/unit/test_disabled_hosts.js
+++ b/toolkit/components/passwordmgr/test/unit/test_disabled_hosts.js
@@ -138,20 +138,46 @@ add_task(function test_rememberSignons()
 
   // Clean up.
   Services.logins.setLoginSavingEnabled(hostname2, true);
   LoginTestUtils.assertDisabledHostsEqual(Services.logins.getAllDisabledHosts(),
                                           []);
 });
 
 /**
- * Tests storing disabled hosts containing non-ASCII characters.
+ * Tests storing disabled hosts with non-ASCII characters where IDN is supported.
  */
-add_task(function* test_storage_setLoginSavingEnabled_nonascii()
+add_task(function* test_storage_setLoginSavingEnabled_nonascii_IDN_is_supported()
 {
-  let hostname = "http://" + String.fromCharCode(355) + ".example.com";
+  let hostname = "http://大.net";
+  let encoding = "http://xn--pss.net";
+
   Services.logins.setLoginSavingEnabled(hostname, false);
 
   yield* LoginTestUtils.reloadData();
+
+  Assert.equal(Services.logins.getLoginSavingEnabled(hostname), false);
+  Assert.equal(Services.logins.getLoginSavingEnabled(encoding), false);
   LoginTestUtils.assertDisabledHostsEqual(Services.logins.getAllDisabledHosts(),
                                           [hostname]);
+
   LoginTestUtils.clearData();
 });
+
+/**
+ * Tests storing disabled hosts with non-ASCII characters where IDN is not supported.
+ */
+add_task(function* test_storage_setLoginSavingEnabled_nonascii_IDN_not_supported()
+{
+  let hostname = "http://√.com";
+  let encoding = "http://xn--19g.com";
+
+  Services.logins.setLoginSavingEnabled(hostname, false);
+
+  yield* LoginTestUtils.reloadData();
+
+  Assert.equal(Services.logins.getLoginSavingEnabled(hostname), false);
+  Assert.equal(Services.logins.getLoginSavingEnabled(encoding), false);
+  LoginTestUtils.assertDisabledHostsEqual(Services.logins.getAllDisabledHosts(),
+                                          [encoding]);
+
+  LoginTestUtils.clearData();
+});