Bug 1049975 - Part 2: Make effect writable in Animation.webidl. draft
authorBoris Chiou <boris.chiou@gmail.com>
Tue, 12 Jul 2016 18:05:48 +0800
changeset 405230 0a6fb0c0d6eac014233cbce43f26dc61c0aa7aff
parent 405229 96a04750a707a14ddce8caf1de28e215914f9b9f
child 405231 c892d73b7fc6454602a515e3422122c983a80f1b
push id27442
push userbmo:boris.chiou@gmail.com
push dateThu, 25 Aug 2016 04:26:27 +0000
bugs1049975
milestone51.0a1
Bug 1049975 - Part 2: Make effect writable in Animation.webidl. MozReview-Commit-ID: HB4iWPXGkou
dom/animation/Animation.h
dom/webidl/Animation.webidl
--- a/dom/animation/Animation.h
+++ b/dom/animation/Animation.h
@@ -93,16 +93,20 @@ public:
   static already_AddRefed<Animation>
   Constructor(const GlobalObject& aGlobal,
               KeyframeEffectReadOnly* aEffect,
               const Optional<AnimationTimeline*>& aTimeline,
               ErrorResult& aRv);
   void GetId(nsAString& aResult) const { aResult = mId; }
   void SetId(const nsAString& aId);
   KeyframeEffectReadOnly* GetEffect() const { return mEffect; }
+  void SetEffect(AnimationEffectReadOnly* aEffect)
+  {
+    // TODO: Merged with SetEffect(KeyframeEffectReadOnly*) in the next patch.
+  }
   void SetEffect(KeyframeEffectReadOnly* aEffect);
   AnimationTimeline* GetTimeline() const { return mTimeline; }
   void SetTimeline(AnimationTimeline* aTimeline);
   Nullable<TimeDuration> GetStartTime() const { return mStartTime; }
   void SetStartTime(const Nullable<TimeDuration>& aNewStartTime);
   Nullable<TimeDuration> GetCurrentTime() const;
   void SetCurrentTime(const TimeDuration& aNewCurrentTime);
   double PlaybackRate() const { return mPlaybackRate; }
--- a/dom/webidl/Animation.webidl
+++ b/dom/webidl/Animation.webidl
@@ -12,19 +12,18 @@
 
 enum AnimationPlayState { "idle", "pending", "running", "paused", "finished" };
 
 [Func="nsDocument::IsElementAnimateEnabled",
  Constructor (optional KeyframeEffectReadOnly? effect = null,
               optional AnimationTimeline? timeline)]
 interface Animation : EventTarget {
   attribute DOMString id;
-  // Bug 1049975: Make 'effect' writeable
   [Func="nsDocument::IsWebAnimationsEnabled", Pure]
-  readonly attribute AnimationEffectReadOnly? effect;
+  attribute AnimationEffectReadOnly? effect;
   [Func="nsDocument::IsWebAnimationsEnabled"]
   attribute AnimationTimeline? timeline;
   [BinaryName="startTimeAsDouble"]
   attribute double? startTime;
   [SetterThrows, BinaryName="currentTimeAsDouble"]
   attribute double? currentTime;
 
            attribute double             playbackRate;