MozReview: Update Diff Viewer and grid styles (Bug 1056377). r?smacleod draft
authorDavid Walsh <dwalsh@mozilla.com>
Thu, 21 Jul 2016 10:07:00 -0500
changeset 8999 e14617ae723b2845496b068eab3092ab419be89a
parent 8998 90702e22fe536303d8608d29ea76b539e3663d3c
push id1045
push userbmo:dwalsh@mozilla.com
push dateThu, 21 Jul 2016 15:22:19 +0000
reviewerssmacleod
bugs1056377
MozReview: Update Diff Viewer and grid styles (Bug 1056377). r?smacleod MozReview-Commit-ID: 1IAYxhjXZ9J
pylib/mozreview/mozreview/static/mozreview/css/commits.less
pylib/mozreview/mozreview/static/mozreview/css/mozilla-theme-common.less
pylib/mozreview/mozreview/static/mozreview/css/mozilla-theme-reviews.less
pylib/mozreview/mozreview/static/mozreview/css/mozilla-theme.less
--- a/pylib/mozreview/mozreview/static/mozreview/css/commits.less
+++ b/pylib/mozreview/mozreview/static/mozreview/css/commits.less
@@ -141,19 +141,18 @@
      font-family: monospace
    }
 
    /* This was copied from the rb dashboard less file.*/
     .approval,
     .issue-count,
     .no-approval,
     .shipit-count {
-      min-width: 80px;
       text-align: center;
-      display: inline-block;
+      display: block;
       white-space: nowrap;
       min-height: 10pt;
       .border-radius(2px);
     }
 
     .no-approval {
       background-repeat: no-repeat;
       cursor: default;
--- a/pylib/mozreview/mozreview/static/mozreview/css/mozilla-theme-common.less
+++ b/pylib/mozreview/mozreview/static/mozreview/css/mozilla-theme-common.less
@@ -1,8 +1,10 @@
 @moz-blue-dark: #d4dde4;
 @moz-blue-light: #eaeff2;
 
+@light-white: rgba(255, 255, 255, 0.6);
+
 .border-radius(...) {
   -moz-border-radius: @arguments;
   -webkit-border-radius: @arguments;
   border-radius: @arguments;
 }
--- a/pylib/mozreview/mozreview/static/mozreview/css/mozilla-theme-reviews.less
+++ b/pylib/mozreview/mozreview/static/mozreview/css/mozilla-theme-reviews.less
@@ -10,17 +10,17 @@
 
   .content .field-container > pre {
     border: 1px dashed #999;
   }
 }
 
 .reviewable-page #mozreview-child-requests > thead > tr > .status,
 .reviewable-page #mozreview-child-requests > tbody > tr > .status {
-  min-width: 50px;
+  min-width: 86px;
 }
 
 /* Review Actions Bar */
 .actions-container, .actions.page-tabs {
   background: @moz-blue-dark;
   border: 0;
 }
 
--- a/pylib/mozreview/mozreview/static/mozreview/css/mozilla-theme.less
+++ b/pylib/mozreview/mozreview/static/mozreview/css/mozilla-theme.less
@@ -113,8 +113,184 @@ body {
 
 /* Search Bar */
 #headerbar #search input,
 .reviewable-page #headerbar #search input {
   .border-radius(0);
   padding: 3px 6px;
   border-color: #bbb;
 }
+
+/* Diff Tables and Data Grids */
+#page-container {
+  #page_sidebar {
+    .page-sidebar-items {
+      li.has-url {
+        &:hover {
+          .page-sidebar-row {
+            .border-radius(0);
+            background: @light-white;
+            border-color: transparent !important;
+          }
+        }
+      }
+
+      li.active {
+        .page-sidebar-row {
+          .border-radius(0);
+          border: 0 !important;
+        }
+      }
+
+      li.active.has-url {
+        &:hover {
+          .page-sidebar-row {
+            border: 0 !important;
+          }
+        }
+      }
+
+      li {
+        .page-sidebar-row {
+          font-size: 14px;
+        }
+      }
+    }
+  }
+
+  .datagrid-header {
+    background: @moz-blue-dark;
+  }
+}
+
+body.datagrid-page {
+  #page-container {
+    .datagrid-main {
+      .border-radius(0);
+      border: 0 !important;
+    }
+
+    .datagrid-head {
+      .border-radius(0);
+      border-bottom: 0;
+    }
+
+    .datagrid-body {
+      .datagrid-headers {
+        .border-radius(0);
+        border-bottom: 0;
+      }
+    }
+
+    .datagrid-header {
+      &:first-child {
+        border-top-left-radius: 0;
+      }
+      &:last-child {
+        border-top-right-radius: 0;
+      }
+    }
+
+    .datagrid {
+      tbody {
+        td {
+          padding: 10px;
+        }
+        th {
+          padding: 10px;
+        }
+        tr {
+          &:hover {
+            background: @moz-blue-light;
+          }
+        }
+      }
+    }
+
+    .datagrid-wrapper {
+      .datagrid-titlebox {
+        margin-left: 0;
+      }
+    }
+
+
+    .datagrid-title-tabs .datagrid-tab {
+      border: 0;
+
+      &.active {
+        background: @moz-blue-dark;
+      }
+
+      &:first-child {
+        border-top-left-radius: 0;
+      }
+
+      &:last-child {
+        border-top-right-radius: 0;
+      }
+    }
+  }
+}
+
+.datagrid-header-drag.datagrid-header {
+  background: @moz-blue-dark;
+}
+
+.datagrid tr.datagrid-empty-row {
+  visibility: hidden;
+}
+
+.datagrid-titlebox ul li a, a.markdown-info {
+  color: #777;
+}
+
+.datagrid-header {
+  padding: 10px;
+}
+
+#view_controls {
+  font-size: 12px;
+}
+
+.review-request #review_request_details {
+  border-left: 1px solid @moz-blue-light;
+  padding: 0 20px;
+}
+
+/* Diffs in Reviews */
+#diffs .diff-box {
+  .border-radius(0);
+  border: 0;
+}
+
+.sidebyside thead {
+  .filename-row th {
+    background: @moz-blue-dark;
+  }
+
+  .revision-row th .rb-icon {
+    vertical-align: sub;
+  }
+}
+
+/* Dialogs */
+.modalbox-inner, .modalbox-title, .modalbox {
+  background-image: none;
+  .border-radius(0);
+}
+
+.modalbox-title {
+  background: @moz-blue-dark;
+  border-bottom-color: #888a85;
+}
+
+.modalbox-inner {
+  background: @moz-blue-light;
+}
+
+.modalbox-bg {
+  background: @light-white !important; /* overriding JS */
+}
+
+/* Comment Dialogs */
+.comment-dlg {
+  .border-radius(0);
+}