Bug 1283370. Part 6 - remove asserting |mReader->IsWaitForDataSupported()| for mReader->WaitForData() will crash if the method has no override. r=kaku draft
authorJW Wang <jwwang@mozilla.com>
Fri, 01 Jul 2016 11:46:00 +0800
changeset 384378 79f092e64ac84983262100bc50eaec2b9471cd90
parent 384377 c2775fdc05e8557f098363bd682881642c7f183f
child 384379 d8d2b60be9a17f35ed65dbb8e0defe14f7584f4b
push id22256
push userjwwang@mozilla.com
push dateWed, 06 Jul 2016 06:43:32 +0000
reviewerskaku
bugs1283370
milestone50.0a1
Bug 1283370. Part 6 - remove asserting |mReader->IsWaitForDataSupported()| for mReader->WaitForData() will crash if the method has no override. r=kaku MozReview-Commit-ID: DrINZu4fkKl
dom/media/NextFrameSeekTask.cpp
--- a/dom/media/NextFrameSeekTask.cpp
+++ b/dom/media/NextFrameSeekTask.cpp
@@ -347,18 +347,16 @@ NextFrameSeekTask::OnVideoNotDecoded(Med
     // delegate the decode error to the generic error path.
     RejectIfExist(__func__);
     return;
   }
 
   // If the decoder is waiting for data, we tell it to call us back when the
   // data arrives.
   if (aReason == MediaDecoderReader::WAITING_FOR_DATA) {
-    MOZ_ASSERT(mReader->IsWaitForDataSupported(),
-               "Readers that send WAITING_FOR_DATA need to implement WaitForData");
     mReader->WaitForData(MediaData::VIDEO_DATA);
 
     // We are out of data to decode and will enter buffering mode soon.
     // We want to play the frames we have already decoded, so we stop pre-rolling
     // and ensure that loadeddata is fired as required.
     mNeedToStopPrerollingVideo = true;
     return;
   }