Bug 1283478 - Tapping the download notification does not open the downloaded file r?mcomella draft
authorJonathan Almeida (:jonalmeida) <jonalmeida942@gmail.com>
Tue, 05 Jul 2016 15:44:17 -0700
changeset 384264 f11578796b11ad05c4bc30984dc6b518b2d80176
parent 382967 487b2d6d4ad44bde4e2290f0b1ee929abd5ad35d
child 524670 88b132b1a570beeee0b8305c5321fd6230681b6b
push id22233
push userjonalmeida942@gmail.com
push dateTue, 05 Jul 2016 23:53:45 +0000
reviewersmcomella
bugs1283478
milestone50.0a1
Bug 1283478 - Tapping the download notification does not open the downloaded file r?mcomella We were incorrectly retrieving the cookie from the notification intent and passing that along which affected the invocation of the notification. MozReview-Commit-ID: FxL8sw6lByJ
mobile/android/base/java/org/mozilla/gecko/NotificationHelper.java
--- a/mobile/android/base/java/org/mozilla/gecko/NotificationHelper.java
+++ b/mobile/android/base/java/org/mozilla/gecko/NotificationHelper.java
@@ -115,17 +115,17 @@ public final class NotificationHelper im
         final Uri data = intent.getData();
 
         final String notificationType = data.getQueryParameter(EVENT_TYPE_ATTR);
 
         try {
             args.put(ID_ATTR, data.getQueryParameter(ID_ATTR));
             args.put(EVENT_TYPE_ATTR, notificationType);
             args.put(HANDLER_ATTR, data.getQueryParameter(HANDLER_ATTR));
-            args.put(COOKIE_ATTR, data.getQueryParameter(COOKIE_ATTR));
+            args.put(COOKIE_ATTR, intent.getStringExtra(COOKIE_ATTR));
 
             if (BUTTON_EVENT.equals(notificationType)) {
                 final String actionName = data.getQueryParameter(ACTION_ID_ATTR);
                 args.put(ACTION_ID_ATTR, actionName);
             }
 
             Log.i(LOGTAG, "Send " + args.toString());
             GeckoAppShell.notifyObservers("Notification:Event", args.toString());