Bug 1284544 - Remove redundant flag from PackageManager.queryIntentServices r?mcomella draft
authorAndrzej Hunt <ahunt@mozilla.com>
Tue, 05 Jul 2016 09:12:47 -0700
changeset 384133 f3e654849fff8a1bd0e10566e5382991d47cefb4
parent 384132 0d298d5f1245286f5946d544422b87e6a51c04ed
child 524614 b27c07385b4c541b93a0655857caec57958b1c44
push id22173
push userahunt@mozilla.com
push dateTue, 05 Jul 2016 16:19:42 +0000
reviewersmcomella
bugs1284544
milestone50.0a1
Bug 1284544 - Remove redundant flag from PackageManager.queryIntentServices r?mcomella GET_SERVICES is already implicit in this method name. Using lint running against sdk 24 we get a warning that GET_SERVICES isn't a permitted flag. (Previous sdks didn't yet contain a list of allowable flags.) MozReview-Commit-ID: LINassWOTfc
mobile/android/base/java/org/mozilla/gecko/GeckoAppShell.java
--- a/mobile/android/base/java/org/mozilla/gecko/GeckoAppShell.java
+++ b/mobile/android/base/java/org/mozilla/gecko/GeckoAppShell.java
@@ -1510,17 +1510,17 @@ public class GeckoAppShell
             } catch (IOException ex) {
                 // Do nothing.
             }
         }
 
         ArrayList<String> directories = new ArrayList<String>();
         PackageManager pm = getApplicationContext().getPackageManager();
         List<ResolveInfo> plugins = pm.queryIntentServices(new Intent(PLUGIN_ACTION),
-                PackageManager.GET_SERVICES | PackageManager.GET_META_DATA);
+                PackageManager.GET_META_DATA);
 
         synchronized (mPackageInfoCache) {
 
             // clear the list of existing packageInfo objects
             mPackageInfoCache.clear();
 
 
             for (ResolveInfo info : plugins) {