Bug 1117833 - Cancel pending visit and save immediately when title is updated. r?mcomella draft
authorTom Klein <twointofive@gmail.com>
Thu, 30 Jun 2016 23:39:29 -0500
changeset 384079 57cc0877850ebaf8275d4f5515a25523f0e1fed9
parent 382391 b69a5bbb5e40bd426e35222baa600b481e50d265
child 524608 2a2f2e2b1d6d95623b907bb30a17a4ed3e6ec781
push id22167
push userbmo:twointofive@gmail.com
push dateTue, 05 Jul 2016 15:46:38 +0000
reviewersmcomella
bugs1117833
milestone50.0a1
Bug 1117833 - Cancel pending visit and save immediately when title is updated. r?mcomella MozReview-Commit-ID: 3eSyovpfO3A
mobile/android/components/build/nsAndroidHistory.cpp
--- a/mobile/android/components/build/nsAndroidHistory.cpp
+++ b/mobile/android/components/build/nsAndroidHistory.cpp
@@ -282,16 +282,20 @@ nsAndroidHistory::SetURITitle(nsIURI *aU
   if (IsEmbedURI(aURI)) {
     return NS_OK;
   }
 
   if (jni::IsAvailable()) {
     nsAutoCString uri;
     nsresult rv = aURI->GetSpec(uri);
     if (NS_FAILED(rv)) return rv;
+    if (RemovePendingVisitURI(aURI)) {
+      // We have a title, so aURI isn't a redirect, so save the visit now before setting the title.
+      SaveVisitURI(aURI);
+    }
     NS_ConvertUTF8toUTF16 uriString(uri);
     widget::GeckoAppShell::SetURITitle(uriString, aTitle);
   }
   return NS_OK;
 }
 
 NS_IMETHODIMP
 nsAndroidHistory::NotifyVisited(nsIURI *aURI)