bug 1224022 document mLifecycleState multithread access management r?padenot draft
authorKarl Tomlinson <karlt+@karlt.net>
Mon, 04 Jul 2016 16:33:05 +1200
changeset 383460 decc9755fcc57a56d10f22ed9fbb1d6af528b668
parent 383328 39dffbba764210b25bfc1e749b4f16db77fa0d46
child 383461 4808ecb23adbd0a304151074ce9656b05012602b
child 383466 cce2431572b3d148458b46a3cffdd6efcbb4cd79
push id22036
push userktomlinson@mozilla.com
push dateMon, 04 Jul 2016 08:46:28 +0000
reviewerspadenot
bugs1224022
milestone50.0a1
bug 1224022 document mLifecycleState multithread access management r?padenot MozReview-Commit-ID: 8FJlWn99DJo
dom/media/MediaStreamGraphImpl.h
--- a/dom/media/MediaStreamGraphImpl.h
+++ b/dom/media/MediaStreamGraphImpl.h
@@ -738,16 +738,19 @@ public:
     // to shut down the graph thread(s).
     LIFECYCLE_WAITING_FOR_THREAD_SHUTDOWN,
     // Graph threads have shut down but we're waiting for remaining streams
     // to be destroyed. Only happens during application shutdown and on
     // completed non-realtime graphs, since normally we'd only shut down a
     // realtime graph when it has no streams.
     LIFECYCLE_WAITING_FOR_STREAM_DESTRUCTION
   };
+  /**
+   * Modified only on the main thread in mMonitor.
+   */
   LifecycleState mLifecycleState;
   /**
    * The graph should stop processing at or after this time.
    */
   GraphTime mEndTime;
 
   /**
    * True when we need to do a forced shutdown during application shutdown.