reviewboard: remove hover/reveal effects when viewing diffs (bug 1245234) r?davidwalsh draft
authorbyron jones <glob@mozilla.com>
Mon, 04 Jul 2016 16:06:57 +0800
changeset 16 0819eaf9c94464ee942d4b1bdbece95e37faf0eb
parent 14 d1a3a686b1e0b64c1155789bcde2c1fc84c42cf8
push idunknown
push userunknown
push dateunknown
reviewersdavidwalsh
bugs1245234
reviewboard: remove hover/reveal effects when viewing diffs (bug 1245234) r?davidwalsh The controls for expanding diff context are hidden with a slow javascript animation to display. Remove this pain point. Function is commented out instead of removed to minimise merge conflicts. MozReview-Commit-ID: DuLw0U4PiQH
reviewboard/reviewboard/static/rb/js/views/diffFragmentQueueView.js
--- a/reviewboard/reviewboard/static/rb/js/views/diffFragmentQueueView.js
+++ b/reviewboard/reviewboard/static/rb/js/views/diffFragmentQueueView.js
@@ -310,22 +310,24 @@ RB.DiffFragmentQueueView = Backbone.View
         this._tryHideControlsDelayed($expanded);
     },
 
     /*
      * When a comment container loads its contents for the first time, hide its
      * controls and set up the mouseenter and mouseleave events.
      */
     _onFirstLoad: function(id) {
+        /* MozReview: always show controls
         var $container = this.$('#' + this.options.containerPrefix + '_' + id);
 
         this._hideControls($container, true);
 
         $container.hover(_.partial(this._tryShowControlsDelayed, $container),
                          _.partial(this._tryHideControlsDelayed, $container));
+        */
     },
 
     /*
      * Attempt to hide the controls in the given container after a delay.
      */
     _tryShowControlsDelayed: function($container) {
         _.delay(_.bind(function() {
             if ($container.is(':hover')) {