Bug 906116 - part3.1: Replace NS_STYLE_HINT_FRAMECHANGE with nsChangeHint_ReconstructFrame.
Replace NS_STYLE_HINT_FRAMECHANGE with nsChangeHint_ReconstructFrame in
nsStyle*::CalcDifference.
MozReview-Commit-ID: 85WPCyYolal
--- a/layout/style/nsStyleStruct.cpp
+++ b/layout/style/nsStyleStruct.cpp
@@ -685,20 +685,20 @@ nsStyleList::GetQuotePairs() const
nsChangeHint
nsStyleList::CalcDifference(const nsStyleList& aNewData) const
{
// If the quotes implementation is ever going to change we might not need
// a framechange here and a reflow should be sufficient. See bug 35768.
if (mQuotes != aNewData.mQuotes &&
(mQuotes || aNewData.mQuotes) &&
GetQuotePairs() != aNewData.GetQuotePairs()) {
- return NS_STYLE_HINT_FRAMECHANGE;
+ return nsChangeHint_ReconstructFrame;
}
if (mListStylePosition != aNewData.mListStylePosition) {
- return NS_STYLE_HINT_FRAMECHANGE;
+ return nsChangeHint_ReconstructFrame;
}
if (EqualImages(mListStyleImage, aNewData.mListStyleImage) &&
mCounterStyle == aNewData.mCounterStyle) {
if (mImageRegion.IsEqualInterior(aNewData.mImageRegion)) {
return NS_STYLE_HINT_NONE;
}
if (mImageRegion.width == aNewData.mImageRegion.width &&
mImageRegion.height == aNewData.mImageRegion.height) {
@@ -755,17 +755,17 @@ nsStyleXUL::CalcDifference(const nsStyle
mBoxFlex == aNewData.mBoxFlex &&
mBoxOrient == aNewData.mBoxOrient &&
mBoxPack == aNewData.mBoxPack &&
mBoxOrdinal == aNewData.mBoxOrdinal &&
mStretchStack == aNewData.mStretchStack) {
return NS_STYLE_HINT_NONE;
}
if (mBoxOrdinal != aNewData.mBoxOrdinal) {
- return NS_STYLE_HINT_FRAMECHANGE;
+ return nsChangeHint_ReconstructFrame;
}
return NS_STYLE_HINT_REFLOW;
}
// --------------------
// nsStyleColumn
//
/* static */ const uint32_t nsStyleColumn::kMaxColumnCount = 1000;
@@ -808,17 +808,17 @@ nsChangeHint
nsStyleColumn::CalcDifference(const nsStyleColumn& aNewData) const
{
if ((mColumnWidth.GetUnit() == eStyleUnit_Auto)
!= (aNewData.mColumnWidth.GetUnit() == eStyleUnit_Auto) ||
mColumnCount != aNewData.mColumnCount) {
// We force column count changes to do a reframe, because it's tricky to handle
// some edge cases where the column count gets smaller and content overflows.
// XXX not ideal
- return NS_STYLE_HINT_FRAMECHANGE;
+ return nsChangeHint_ReconstructFrame;
}
if (mColumnWidth != aNewData.mColumnWidth ||
mColumnGap != aNewData.mColumnGap ||
mColumnFill != aNewData.mColumnFill) {
return NS_STYLE_HINT_REFLOW;
}
@@ -1749,17 +1749,17 @@ nsStyleTable::nsStyleTable(const nsStyle
MOZ_COUNT_CTOR(nsStyleTable);
}
nsChangeHint
nsStyleTable::CalcDifference(const nsStyleTable& aNewData) const
{
if (mSpan != aNewData.mSpan ||
mLayoutStrategy != aNewData.mLayoutStrategy) {
- return NS_STYLE_HINT_FRAMECHANGE;
+ return nsChangeHint_ReconstructFrame;
}
return NS_STYLE_HINT_NONE;
}
// -----------------------
// nsStyleTableBorder
nsStyleTableBorder::nsStyleTableBorder(StyleStructContext aContext)
@@ -1790,17 +1790,17 @@ nsStyleTableBorder::nsStyleTableBorder(c
nsChangeHint
nsStyleTableBorder::CalcDifference(const nsStyleTableBorder& aNewData) const
{
// Border-collapse changes need a reframe, because we use a different frame
// class for table cells in the collapsed border model. This is used to
// conserve memory when using the separated border model (collapsed borders
// require extra state to be stored).
if (mBorderCollapse != aNewData.mBorderCollapse) {
- return NS_STYLE_HINT_FRAMECHANGE;
+ return nsChangeHint_ReconstructFrame;
}
if ((mCaptionSide == aNewData.mCaptionSide) &&
(mBorderSpacingCol == aNewData.mBorderSpacingCol) &&
(mBorderSpacingRow == aNewData.mBorderSpacingRow)) {
if (mEmptyCells == aNewData.mEmptyCells) {
return NS_STYLE_HINT_NONE;
}
@@ -3488,40 +3488,40 @@ nsStyleContent::CalcDifference(const nsS
// the optimization in ReResolveStyleContext is ok. But if we ever
// change this code to not reconstruct frames on changes to the
// 'content' property, then we will need to revisit the optimization
// in ReResolveStyleContext.
if (mContentCount != aNewData.mContentCount ||
mIncrementCount != aNewData.mIncrementCount ||
mResetCount != aNewData.mResetCount) {
- return NS_STYLE_HINT_FRAMECHANGE;
+ return nsChangeHint_ReconstructFrame;
}
uint32_t ix = mContentCount;
while (0 < ix--) {
if (mContents[ix] != aNewData.mContents[ix]) {
// Unfortunately we need to reframe here; a simple reflow
// will not pick up different text or different image URLs,
// since we set all that up in the CSSFrameConstructor
- return NS_STYLE_HINT_FRAMECHANGE;
+ return nsChangeHint_ReconstructFrame;
}
}
ix = mIncrementCount;
while (0 < ix--) {
if ((mIncrements[ix].mValue != aNewData.mIncrements[ix].mValue) ||
(mIncrements[ix].mCounter != aNewData.mIncrements[ix].mCounter)) {
- return NS_STYLE_HINT_FRAMECHANGE;
+ return nsChangeHint_ReconstructFrame;
}
}
ix = mResetCount;
while (0 < ix--) {
if ((mResets[ix].mValue != aNewData.mResets[ix].mValue) ||
(mResets[ix].mCounter != aNewData.mResets[ix].mCounter)) {
- return NS_STYLE_HINT_FRAMECHANGE;
+ return nsChangeHint_ReconstructFrame;
}
}
if (mMarkerOffset != aNewData.mMarkerOffset) {
return NS_STYLE_HINT_REFLOW;
}
return NS_STYLE_HINT_NONE;
}
@@ -3711,17 +3711,17 @@ nsStyleText::~nsStyleText()
}
nsChangeHint
nsStyleText::CalcDifference(const nsStyleText& aNewData) const
{
if (WhiteSpaceOrNewlineIsSignificant() !=
aNewData.WhiteSpaceOrNewlineIsSignificant()) {
// This may require construction of suppressed text frames
- return NS_STYLE_HINT_FRAMECHANGE;
+ return nsChangeHint_ReconstructFrame;
}
if (mTextCombineUpright != aNewData.mTextCombineUpright ||
mControlCharacterVisibility != aNewData.mControlCharacterVisibility) {
return nsChangeHint_ReconstructFrame;
}
if ((mTextAlign != aNewData.mTextAlign) ||
@@ -3908,17 +3908,17 @@ nsStyleUserInterface::CalcDifference(con
if (mUserModify != aNewData.mUserModify) {
hint |= NS_STYLE_HINT_VISUAL;
}
if (mUserInput != aNewData.mUserInput) {
if (NS_STYLE_USER_INPUT_NONE == mUserInput ||
NS_STYLE_USER_INPUT_NONE == aNewData.mUserInput) {
- hint |= NS_STYLE_HINT_FRAMECHANGE;
+ hint |= nsChangeHint_ReconstructFrame;
} else {
hint |= nsChangeHint_NeutralChange;
}
}
if (mUserFocus != aNewData.mUserFocus) {
hint |= nsChangeHint_NeutralChange;
}
@@ -3971,17 +3971,17 @@ nsStyleUIReset::~nsStyleUIReset()
MOZ_COUNT_DTOR(nsStyleUIReset);
}
nsChangeHint
nsStyleUIReset::CalcDifference(const nsStyleUIReset& aNewData) const
{
// ignore mIMEMode
if (mForceBrokenImageIcon != aNewData.mForceBrokenImageIcon) {
- return NS_STYLE_HINT_FRAMECHANGE;
+ return nsChangeHint_ReconstructFrame;
}
if (mWindowShadow != aNewData.mWindowShadow) {
// We really need just an nsChangeHint_SyncFrameView, except
// on an ancestor of the frame, so we get that by doing a
// reflow.
return NS_STYLE_HINT_REFLOW;
}
if (mUserSelect != aNewData.mUserSelect) {