Bug 934512 - Mark MediaStream source node as active while it has live audio tracks. r?padenot draft
authorAndreas Pehrson <pehrsons@gmail.com>
Mon, 27 Jun 2016 17:30:01 +0200
changeset 382265 4c4502793194961a0bb9ddbec6ae589a7f11ada7
parent 382264 25ad359798267fb69a8278a8845d6950bc443186
child 524152 12fe09c0252020cd598c5343f0165389622bc755
push id21678
push userpehrsons@gmail.com
push dateWed, 29 Jun 2016 12:45:55 +0000
reviewerspadenot
bugs934512
milestone50.0a1
Bug 934512 - Mark MediaStream source node as active while it has live audio tracks. r?padenot MozReview-Commit-ID: F78FmUMMm6N
dom/media/webaudio/MediaStreamAudioSourceNode.cpp
--- a/dom/media/webaudio/MediaStreamAudioSourceNode.cpp
+++ b/dom/media/webaudio/MediaStreamAudioSourceNode.cpp
@@ -128,18 +128,22 @@ MediaStreamAudioSourceNode::AttachToFirs
   aMediaStream->GetAudioTracks(tracks);
 
   for (const RefPtr<AudioStreamTrack>& track : tracks) {
     if (track->Ended()) {
       continue;
     }
 
     AttachToTrack(track);
+    MarkActive();
     return;
   }
+
+  // There was no track available. We'll allow the node to be garbage collected.
+  MarkInactive();
 }
 
 void
 MediaStreamAudioSourceNode::NotifyTrackAdded(const RefPtr<MediaStreamTrack>& aTrack)
 {
   if (mInputTrack) {
     return;
   }