MozReview: Open 'MozReview' header links in new window (Bug 1275305). r?glob draft
authorDavid Walsh <dwalsh@mozilla.com>
Tue, 28 Jun 2016 12:07:51 -0500
changeset 8674 034dafee996c820778d5c4edc3068ac1536d2d92
parent 8634 516d9bb2641d38dfb8473fbfb0bf745986327626
push id961
push userbmo:dwalsh@mozilla.com
push dateTue, 28 Jun 2016 17:08:02 +0000
reviewersglob
bugs1275305
MozReview: Open 'MozReview' header links in new window (Bug 1275305). r?glob MozReview-Commit-ID: KBa4TdYpPyy
pylib/mozreview/mozreview/extension.py
pylib/mozreview/mozreview/static/mozreview/js/default.js
--- a/pylib/mozreview/mozreview/extension.py
+++ b/pylib/mozreview/mozreview/extension.py
@@ -193,16 +193,17 @@ class MozReviewExtension(Extension):
         set_diff_opcode_generator_class(NoFilterDiffOpcodeGenerator)
 
         initialize_pulse_handlers(self)
 
         URLHook(self,
                 patterns('', url(r'^mozreview/', include('mozreview.urls'))))
 
         HeaderDropdownActionHook(self, actions=[{
+            'id': 'nav-mozreview-menu',
             'label': 'MozReview',
             'items': [
                 {
                     'label': 'User Guide',
                     'url': 'https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview-user.html',
                 },
                 {
                     'label': 'Mercurial for Mozillians',
--- a/pylib/mozreview/mozreview/static/mozreview/js/default.js
+++ b/pylib/mozreview/mozreview/static/mozreview/js/default.js
@@ -3,9 +3,12 @@
   $('#navbar a[href="/r/new/"]').parent('li').remove();
 
   // Fix logout url
   $("a[href='/account/logout/']").attr("href", "/mozreview/logout/");
   $("#accountnav li").css("visibility", "visible");
 
   // Hide "Close Discarded" and "Close Submitted" in request listings
   $('#page_sidebar').find('a.discard, a.submit').remove();
+
+  // Open MozReview subnav items in a new window
+  $('#nav-mozreview-menu').parent().find('li a').attr('target', '_blank');
 });