Bug 1266369 - (Pre) FloatingToolbarTextSelection: Add final keyword where feasible. r?ahunt draft
authorSebastian Kaspari <s.kaspari@gmail.com>
Mon, 27 Jun 2016 11:51:32 +0200
changeset 381470 e32ca99e4dc5ed1a1c007ad7d125ee2206d76b3d
parent 381455 9688cac5afbe215406ac95aa1a7972960666ca1c
child 381471 288b5c7d938dc1f99676961f356f9811d38f3f84
child 381472 506ef8e20778985d490e4ddd519494f45adccfa4
push id21483
push users.kaspari@gmail.com
push dateMon, 27 Jun 2016 11:48:01 +0000
reviewersahunt
bugs1266369
milestone50.0a1
Bug 1266369 - (Pre) FloatingToolbarTextSelection: Add final keyword where feasible. r?ahunt MozReview-Commit-ID: DF7qmGXMfEy
mobile/android/base/java/org/mozilla/gecko/text/FloatingToolbarTextSelection.java
--- a/mobile/android/base/java/org/mozilla/gecko/text/FloatingToolbarTextSelection.java
+++ b/mobile/android/base/java/org/mozilla/gecko/text/FloatingToolbarTextSelection.java
@@ -28,22 +28,22 @@ import ch.boye.httpclientandroidlib.util
 
 /**
  * Floating toolbar for text selection actions. Only on Android 6+.
  */
 @TargetApi(Build.VERSION_CODES.M)
 public class FloatingToolbarTextSelection implements TextSelection, GeckoEventListener {
     private static final String LOGTAG = "GeckoFloatTextSelection";
 
-    private Activity activity;
+    private final Activity activity;
+    private final LayerView layerView;
+    private final int[] locationInWindow;
+
     private ActionMode actionMode;
     private FloatingActionModeCallback actionModeCallback;
-    private LayerView layerView;
-    private int[] locationInWindow;
-
     private String selectionID;
     /* package-private */ Rect contentRect;
 
     public FloatingToolbarTextSelection(Activity activity, LayerView layerView) {
         this.activity = activity;
         this.layerView = layerView;
         this.locationInWindow = new int[2];
     }