Bug 1267403 - calculate spectrum element offset using getBoundingClientRect draft
authorJulian Descottes <jdescottes@mozilla.com>
Thu, 23 Jun 2016 14:23:53 +0200
changeset 380799 d85c73db9b200b6621f9d9cf250dd8373650582b
parent 380798 0707438c73abc441350907fadc6e2d95bdfb9227
child 523823 c2cd3978734bd87ee884ccd65b99d338135420fa
push id21329
push userjdescottes@mozilla.com
push dateThu, 23 Jun 2016 12:25:10 +0000
bugs1267403
milestone50.0a1
Bug 1267403 - calculate spectrum element offset using getBoundingClientRect MozReview-Commit-ID: 5dYyVU9BpHs
devtools/client/shared/widgets/Spectrum.js
--- a/devtools/client/shared/widgets/Spectrum.js
+++ b/devtools/client/shared/widgets/Spectrum.js
@@ -128,28 +128,17 @@ Spectrum.rgbToHsv = function (r, g, b, a
       case b: h = (r - g) / d + 4; break;
     }
     h /= 6;
   }
   return [h, s, v, a];
 };
 
 Spectrum.getOffset = function (el) {
-  let curleft = 0, curtop = 0;
-  if (el.offsetParent) {
-    while (el) {
-      curleft += el.offsetLeft;
-      curtop += el.offsetTop;
-      el = el.offsetParent;
-    }
-  }
-  return {
-    left: curleft,
-    top: curtop
-  };
+  return el.getBoundingClientRect();
 };
 
 Spectrum.draggable = function (element, onmove, onstart, onstop) {
   onmove = onmove || function () {};
   onstart = onstart || function () {};
   onstop = onstop || function () {};
 
   let doc = element.ownerDocument;