Bug 1280600: Use Gecko's 'libgabi++' on b2g, r=glandium draft
authorThomas Zimmermann <tdz@users.sourceforge.net>
Mon, 11 Jul 2016 14:58:37 +0200
changeset 386253 6449100d9ec8c29ba0e06f8e94841d1d2881ae4e
parent 386252 4d1c563576e8a47b63be3a0e5f186a3065324b24
child 525062 481a9d87af696f6f03f354c3ce4d7e1f7f22f923
push id22651
push usertdz@users.sourceforge.net
push dateMon, 11 Jul 2016 13:01:55 +0000
reviewersglandium
bugs1280600
milestone50.0a1
Bug 1280600: Use Gecko's 'libgabi++' on b2g, r=glandium B2g came with its own version of 'libgabi++' in its toolchain. Gecko on b2g isn't build any longer with this toolchain. With this patch applied, Gecko's internal version of 'libgabi++' is used for building. MozReview-Commit-ID: KU4OBYQ6cAW
build/moz.build
config/external/icu/common/moz.build
config/external/icu/defs.mozbuild
--- a/build/moz.build
+++ b/build/moz.build
@@ -12,17 +12,17 @@ SPHINX_TREES['buildsystem'] = 'docs'
 
 if CONFIG['OS_ARCH'] == 'WINNT':
     DIRS += ['win32']
 else:
     DIRS += ['unix']
 
 if CONFIG['OS_TARGET'] == 'Android' and CONFIG['MOZ_ANDROID_CXX_STL'] == 'mozstlport':
     DIRS += ['stlport']
-    if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'android' and CONFIG['ENABLE_INTL_API']:
+    if CONFIG['ENABLE_INTL_API']:
         DIRS += ['gabi++']
 
 if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'android':
     DIRS += ['annotationProcessors']
 
 for var in ('GRE_MILESTONE', 'MOZ_APP_VERSION', 'MOZ_APP_BASENAME',
             'MOZ_APP_VENDOR', 'MOZ_APP_ID', 'MAR_CHANNEL_ID',
             'ACCEPTED_MAR_CHANNEL_IDS', 'MOZ_APP_REMOTINGNAME'):
--- a/config/external/icu/common/moz.build
+++ b/config/external/icu/common/moz.build
@@ -2,21 +2,17 @@
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 Library('icuuc')
 FINAL_LIBRARY = 'icu'
 
-if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk':
-    OS_LIBS += [
-        'gabi++',
-    ]
-if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'android' and CONFIG['MOZ_ANDROID_CXX_STL'] == 'mozstlport':
+if CONFIG['OS_TARGET'] == 'Android' and CONFIG['MOZ_ANDROID_CXX_STL'] == 'mozstlport':
     USE_LIBS += [
         'gabi++'
     ]
 
 DEFINES['U_COMMON_IMPLEMENTATION'] = True
 # This normally gets defined in the SDK but our WINVER is too low.
 #FIXME: should probably stop including mozilla-config.h
 DEFINES['LOCALE_SNAME'] = 0x5c
--- a/config/external/icu/defs.mozbuild
+++ b/config/external/icu/defs.mozbuild
@@ -28,12 +28,10 @@ if not CONFIG['HAVE_LANGINFO_CODESET']:
 if CONFIG['GNU_CXX']:
     CXXFLAGS += ['-frtti']
 elif CONFIG['OS_TARGET'] == 'WINNT':
     CXXFLAGS += ['-GR']
 
 DISABLE_STL_WRAPPING = True
 ALLOW_COMPILER_WARNINGS = True
 
-if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'android' and CONFIG['MOZ_ANDROID_CXX_STL'] == 'mozstlport':
+if CONFIG['OS_TARGET'] == 'Android' and CONFIG['MOZ_ANDROID_CXX_STL'] == 'mozstlport':
     LOCAL_INCLUDES += ['/build/gabi++/include']
-if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk':
-    LOCAL_INCLUDES += ['%' + CONFIG['ANDROID_SOURCE'] + '/abi/cpp/include']