Bug 1280445 - Don't hold on to Image in MediaEngineDefaultVideoSource after Stop(). r?pehrsons
MozReview-Commit-ID: K5NTMrbnAEi
--- a/dom/media/webrtc/MediaEngineDefault.cpp
+++ b/dom/media/webrtc/MediaEngineDefault.cpp
@@ -104,16 +104,17 @@ MediaEngineDefaultVideoSource::Allocate(
nsresult
MediaEngineDefaultVideoSource::Deallocate()
{
if (mState != kStopped && mState != kAllocated) {
return NS_ERROR_FAILURE;
}
mState = kReleased;
+ mImage = nullptr;
return NS_OK;
}
static void AllocateSolidColorFrame(layers::PlanarYCbCrData& aData,
int aWidth, int aHeight,
int aY, int aCb, int aCr)
{
MOZ_ASSERT(!(aWidth&1));
@@ -197,16 +198,17 @@ MediaEngineDefaultVideoSource::Stop(Sour
aSource->EndTrack(aID);
if (mHasFakeTracks) {
for (int i = 0; i < kFakeVideoTrackCount; ++i) {
aSource->EndTrack(kTrackCount + i);
}
}
mState = kStopped;
+ mImage = nullptr;
return NS_OK;
}
nsresult
MediaEngineDefaultVideoSource::Restart(const dom::MediaTrackConstraints& aConstraints,
const MediaEnginePrefs &aPrefs,
const nsString& aDeviceId)
{