Bug 1280101 - Do not coerce window dimensions to integer; r?automatedtester draft
authorAndreas Tolfsen <ato@mozilla.com>
Tue, 14 Jun 2016 18:57:02 +0100
changeset 380227 59cdaa8ed114f94cc5bb1c1ecc0c4edf13419ddb
parent 379985 3c5025f98e561a20e24d97c91a9e4e0ec28015ea
child 380228 29b979d401e583e0a4c1af7d830bf83438ce76f7
push id21171
push userbmo:ato@mozilla.com
push dateTue, 21 Jun 2016 08:19:42 +0000
reviewersautomatedtester
bugs1280101
milestone50.0a1
Bug 1280101 - Do not coerce window dimensions to integer; r?automatedtester The specification says nothing about coercing to integer. MozReview-Commit-ID: Cq5Wbo2vIAD
testing/marionette/driver.js
--- a/testing/marionette/driver.js
+++ b/testing/marionette/driver.js
@@ -2485,18 +2485,18 @@ GeckoDriver.prototype.getWindowSize = fu
  * An error will be returned if the requested window size would result
  * in the window being in the maximized state.
  */
 GeckoDriver.prototype.setWindowSize = function(cmd, resp) {
   if (this.appName != "Firefox") {
     throw new UnsupportedOperationError();
   }
 
-  let width = parseInt(cmd.parameters.width);
-  let height = parseInt(cmd.parameters.height);
+  let width = cmd.parameters.width;
+  let height = cmd.parameters.height;
 
   let win = this.getCurrentWindow();
   if (width >= win.screen.availWidth || height >= win.screen.availHeight) {
     throw new UnsupportedOperationError("Requested size exceeds screen size")
   }
 
   win.resizeTo(width, height);
 };