Bug 1279529; Remove the --no-fpu option in the shell; r?jandem
MozReview-Commit-ID: 6rKorIq31YX
--- a/js/src/jit/x86-shared/Assembler-x86-shared.h
+++ b/js/src/jit/x86-shared/Assembler-x86-shared.h
@@ -236,19 +236,16 @@ class CPUInfo
#endif
}
static bool IsSSE3Present() { return GetSSEVersion() >= SSE3; }
static bool IsSSSE3Present() { return GetSSEVersion() >= SSSE3; }
static bool IsSSE41Present() { return GetSSEVersion() >= SSE4_1; }
static bool IsSSE42Present() { return GetSSEVersion() >= SSE4_2; }
static bool IsPOPCNTPresent() { return popcntPresent; }
-#ifdef JS_CODEGEN_X86
- static void SetFloatingPointDisabled() { maxEnabledSSEVersion = NoSSE; avxEnabled = false; }
-#endif
static void SetSSE3Disabled() { maxEnabledSSEVersion = SSE2; avxEnabled = false; }
static void SetSSE4Disabled() { maxEnabledSSEVersion = SSSE3; avxEnabled = false; }
static void SetAVXEnabled() { avxEnabled = true; }
};
class AssemblerX86Shared : public AssemblerShared
{
protected:
--- a/js/src/shell/js.cpp
+++ b/js/src/shell/js.cpp
@@ -7315,18 +7315,16 @@ main(int argc, char** argv, char** envp)
"--ion-parallel compile is deprecated. Use --ion-offthread-compile.")
|| !op.addBoolOption('\0', "baseline", "Enable baseline compiler (default)")
|| !op.addBoolOption('\0', "no-baseline", "Disable baseline compiler")
|| !op.addBoolOption('\0', "baseline-eager", "Always baseline-compile methods")
|| !op.addIntOption('\0', "baseline-warmup-threshold", "COUNT",
"Wait for COUNT calls or iterations before baseline-compiling "
"(default: 10)", -1)
|| !op.addBoolOption('\0', "non-writable-jitcode", "(NOP for fuzzers) Allocate JIT code as non-writable memory.")
- || !op.addBoolOption('\0', "no-fpu", "Pretend CPU does not support floating-point operations "
- "to test JIT codegen (no-op on platforms other than x86).")
|| !op.addBoolOption('\0', "no-sse3", "Pretend CPU does not support SSE3 instructions and above "
"to test JIT codegen (no-op on platforms other than x86 and x64).")
|| !op.addBoolOption('\0', "no-sse4", "Pretend CPU does not support SSE4 instructions"
"to test JIT codegen (no-op on platforms other than x86 and x64).")
|| !op.addBoolOption('\0', "enable-avx", "AVX is disabled by default. Enable AVX. "
"(no-op on platforms other than x86 and x64).")
|| !op.addBoolOption('\0', "no-avx", "No-op. AVX is currently disabled by default.")
|| !op.addBoolOption('\0', "fuzzing-safe", "Don't expose functions that aren't safe for "
@@ -7393,21 +7391,16 @@ main(int argc, char** argv, char** envp)
#ifdef DEBUG
/*
* Process OOM options as early as possible so that we can observe as many
* allocations as possible.
*/
OOM_printAllocationCount = op.getBoolOption('O');
#endif
-#ifdef JS_CODEGEN_X86
- if (op.getBoolOption("no-fpu"))
- js::jit::CPUInfo::SetFloatingPointDisabled();
-#endif
-
#if defined(JS_CODEGEN_X86) || defined(JS_CODEGEN_X64)
if (op.getBoolOption("no-sse3")) {
js::jit::CPUInfo::SetSSE3Disabled();
PropagateFlagToNestedShells("--no-sse3");
}
if (op.getBoolOption("no-sse4")) {
js::jit::CPUInfo::SetSSE4Disabled();
PropagateFlagToNestedShells("--no-sse4");
--- a/js/src/tests/lib/tests.py
+++ b/js/src/tests/lib/tests.py
@@ -14,17 +14,16 @@ from results import TestOutput
# arguments.
JITFLAGS = {
'all': [
[], # no flags, normal baseline and ion
['--ion-eager', '--ion-offthread-compile=off'], # implies --baseline-eager
['--ion-eager', '--ion-offthread-compile=off', '--non-writable-jitcode',
'--ion-check-range-analysis', '--ion-extra-checks', '--no-sse3', '--no-threads'],
['--baseline-eager'],
- ['--baseline-eager', '--no-fpu'],
['--no-baseline', '--no-ion'],
],
# used by jit_test.py
'ion': [
['--baseline-eager'],
['--ion-eager', '--ion-offthread-compile=off']
],
# Run reduced variants on debug builds, since they take longer time.