Bug 1261842 - ContentParent::RecvCreateWindow should always set an nsresult outparam. r?smaug
MozReview-Commit-ID: 79FYAMBIDef
--- a/dom/ipc/ContentParent.cpp
+++ b/dom/ipc/ContentParent.cpp
@@ -5291,16 +5291,17 @@ ContentParent::RecvCreateWindow(PBrowser
bool* aWindowIsNew,
InfallibleTArray<FrameScriptInfo>* aFrameScripts,
nsCString* aURLToLoad,
TextureFactoryIdentifier* aTextureFactoryIdentifier,
uint64_t* aLayersId)
{
// We always expect to open a new window here. If we don't, it's an error.
*aWindowIsNew = true;
+ *aResult = NS_OK;
// The content process should never be in charge of computing whether or
// not a window should be private or remote - the parent will do that.
const uint32_t badFlags =
nsIWebBrowserChrome::CHROME_PRIVATE_WINDOW
| nsIWebBrowserChrome::CHROME_NON_PRIVATE_WINDOW
| nsIWebBrowserChrome::CHROME_PRIVATE_LIFETIME
| nsIWebBrowserChrome::CHROME_REMOTE_WINDOW;