Bug 1278138 - Enforce stricter eslint rules (comma-style) on passwordmgr. r=MattN
MozReview-Commit-ID: A16S8XGZ6Kg
new file mode 100644
--- /dev/null
+++ b/toolkit/components/passwordmgr/.eslintrc
@@ -0,0 +1,10 @@
+{
+ "extends": "../../.eslintrc",
+ "rules": {
+ // No space before always a space after a comma
+ "comma-spacing": [2, {"before": false, "after": true}],
+
+ // Commas at the end of the line not the start
+ "comma-style": 2,
+ }
+}
--- a/toolkit/components/passwordmgr/LoginManagerContent.jsm
+++ b/toolkit/components/passwordmgr/LoginManagerContent.jsm
@@ -1182,17 +1182,17 @@ var LoginUtils = {
uriString = form.baseURI; // ala bug 297761
return this._getPasswordOrigin(uriString, true);
},
};
// nsIAutoCompleteResult implementation
function UserAutoCompleteResult (aSearchString, matchingLogins, messageManager) {
- function loginSort(a,b) {
+ function loginSort(a, b) {
var userA = a.username.toLowerCase();
var userB = b.username.toLowerCase();
if (userA < userB)
return -1;
if (userA > userB)
return 1;
--- a/toolkit/components/passwordmgr/content/passwordManager.js
+++ b/toolkit/components/passwordmgr/content/passwordManager.js
@@ -178,18 +178,18 @@ function LoadSignons() {
// direction but here we don't so we have to trick it
lastSignonSortAscending = !lastSignonSortAscending;
SignonColumnSort(lastSignonSortColumn);
// disable "remove all signons" button if there are no signons
var element = document.getElementById("removeAllSignons");
var toggle = document.getElementById("togglePasswords");
if (signons.length == 0) {
- element.setAttribute("disabled","true");
- toggle.setAttribute("disabled","true");
+ element.setAttribute("disabled", "true");
+ toggle.setAttribute("disabled", "true");
} else {
element.removeAttribute("disabled");
toggle.removeAttribute("disabled");
}
return true;
}
--- a/toolkit/components/passwordmgr/content/passwordManagerCommon.js
+++ b/toolkit/components/passwordmgr/content/passwordManagerCommon.js
@@ -94,17 +94,17 @@ function DeleteAllFromTree(tree, view, t
var box = tree.treeBoxObject;
box.rowCountChanged(0, -deletedTable.length);
box.invalidate();
// disable buttons
document.getElementById(removeButton).setAttribute("disabled", "true")
- document.getElementById(removeAllButton).setAttribute("disabled","true");
+ document.getElementById(removeAllButton).setAttribute("disabled", "true");
}
function DeleteSelectedItemFromTree
(tree, view, table, deletedTable, removeButton, removeAllButton) {
// Turn off tree selection notifications during the deletion
tree.view.selection.selectEventsSuppressed = true;
@@ -133,17 +133,17 @@ function DeleteSelectedItemFromTree
if (table.length) {
// update selection
var nextSelection = (selections[0] < table.length) ? selections[0] : table.length-1;
tree.view.selection.select(nextSelection);
tree.treeBoxObject.ensureRowIsVisible(nextSelection);
} else {
// disable buttons
document.getElementById(removeButton).setAttribute("disabled", "true")
- document.getElementById(removeAllButton).setAttribute("disabled","true");
+ document.getElementById(removeAllButton).setAttribute("disabled", "true");
}
tree.view.selection.selectEventsSuppressed = false;
}
function GetTreeSelections(tree) {
var selections = [];
var select = tree.view.selection;
if (select) {
--- a/toolkit/components/passwordmgr/content/passwordManagerExceptions.js
+++ b/toolkit/components/passwordmgr/content/passwordManagerExceptions.js
@@ -11,33 +11,33 @@ function RejectsStartup() {
let treecols = document.getElementsByTagName("treecols")[0];
treecols.addEventListener("click", HandleTreeColumnClick.bind(null, RejectColumnSort));
}
var rejectsTreeView = {
rowCount : 0,
setTree : function(tree){},
- getImageSrc : function(row,column) {},
- getProgressMode : function(row,column) {},
- getCellValue : function(row,column) {},
- getCellText : function(row,column){
+ getImageSrc : function(row, column) {},
+ getProgressMode : function(row, column) {},
+ getCellValue : function(row, column) {},
+ getCellText : function(row, column){
var rv="";
if (column.id=="rejectCol") {
rv = rejects[row].host;
}
return rv;
},
isSeparator : function(index) {return false;},
isSorted: function() { return false; },
isContainer : function(index) {return false;},
cycleHeader : function(column) {},
getRowProperties : function(row){ return ""; },
getColumnProperties : function(column){ return ""; },
- getCellProperties : function(row,column){
+ getCellProperties : function(row, column){
if (column.element.getAttribute("id") == "rejectCol")
return "ltr";
return "";
}
};
function Reject(number, host) {
@@ -51,17 +51,17 @@ function LoadRejects() {
rejectsTreeView.rowCount = rejects.length;
// sort and display the table
rejectsTree.view = rejectsTreeView;
RejectColumnSort(lastRejectSortColumn);
var element = document.getElementById("removeAllRejects");
if (rejects.length == 0) {
- element.setAttribute("disabled","true");
+ element.setAttribute("disabled", "true");
} else {
element.removeAttribute("disabled");
}
}
function RejectSelected() {
var selections = GetTreeSelections(rejectsTree);
if (selections.length) {
--- a/toolkit/components/passwordmgr/test/unit/test_getPasswordFields.js
+++ b/toolkit/components/passwordmgr/test/unit/test_getPasswordFields.js
@@ -68,24 +68,24 @@ const TESTCASES = [
<form id="form1"></form>`,
returnedFieldIDsByFormLike: [["pw1"], ["pw2"]],
skipEmptyFields: undefined,
},
{
description: "2 password fields outside of a <form> with 1 linked via @form + skipEmpty",
document: `<input id="pw1" type=password><input id="pw2" type=password form="form1">
<form id="form1"></form>`,
- returnedFieldIDsByFormLike: [[],[]],
+ returnedFieldIDsByFormLike: [[], []],
skipEmptyFields: true,
},
{
description: "2 password fields outside of a <form> with 1 linked via @form + skipEmpty with 1 empty",
document: `<input id="pw1" type=password value="pass1"><input id="pw2" type=password form="form1">
<form id="form1"></form>`,
- returnedFieldIDsByFormLike: [["pw1"],[]],
+ returnedFieldIDsByFormLike: [["pw1"], []],
skipEmptyFields: true,
},
];
for (let tc of TESTCASES) {
do_print("Sanity checking the testcase: " + tc.description);
(function() {