Bug 1277854 - Post: add comment explaining local loading r?sebastian draft
authorAndrzej Hunt <ahunt@mozilla.com>
Fri, 03 Jun 2016 10:51:18 -0700
changeset 375216 6a50787f6b16e83e736f8e4257cf117db25901a7
parent 375215 2783bd57df596c301b934ddfd1600cf0d1c81b77
child 522788 e7b472a4715cf61fc15a33b738a016890e880d51
push id20191
push userahunt@mozilla.com
push dateFri, 03 Jun 2016 17:52:29 +0000
reviewerssebastian
bugs1277854
milestone49.0a1
Bug 1277854 - Post: add comment explaining local loading r?sebastian MozReview-Commit-ID: J8eJrzkExeX
mobile/android/base/java/org/mozilla/gecko/favicons/Favicons.java
--- a/mobile/android/base/java/org/mozilla/gecko/favicons/Favicons.java
+++ b/mobile/android/base/java/org/mozilla/gecko/favicons/Favicons.java
@@ -301,18 +301,20 @@ public class Favicons {
             final Bitmap result = getSizedFaviconFromCache(targetURL, targetSize);
             if (result != null) {
                 // Victory - immediate response!
                 return dispatchResult(pageURL, targetURL, result, callback);
             }
         }
 
         // No joy using in-memory resources. Go to background thread and ask the database.
+        // Note: this is a near duplicate of loadUncachedFavicon, however loadUncachedFavicon
+        // can download favicons, whereas we want to restrict ourselves to the cache.
         final LoadFaviconTask task =
-            new LoadFaviconTask(context, pageURL, targetURL, 0, callback, targetSize, true);
+            new LoadFaviconTask(context, pageURL, targetURL, 0, callback, targetSize, /* onlyFromLocal: */ true);
         final int taskId = task.getId();
         synchronized (loadTasks) {
             loadTasks.put(taskId, task);
         }
         task.execute();
 
         return taskId;
     }