Bug 1276977 - remove unused variable and call r?liuche draft
authorAndrzej Hunt <ahunt@mozilla.com>
Thu, 02 Jun 2016 14:54:32 -0700
changeset 374857 9ebc9c17bbedec8ada0ba58a81fafee966b2e83b
parent 374831 be100298e5658b038c1f0c7d52b0f10e653db411
child 522697 45fb817b564cdb637cb490a82b1c3af0d35dec9b
push id20093
push userahunt@mozilla.com
push dateThu, 02 Jun 2016 21:55:17 +0000
reviewersliuche
bugs1276977
milestone49.0a1
Bug 1276977 - remove unused variable and call r?liuche Apparently this code can crash despite the nullcheck, let's completely remove it since we don't use the results. MozReview-Commit-ID: CzHn8kABLYd
mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
--- a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ -2308,18 +2308,16 @@ public class BrowserApp extends GeckoApp
             panelId = null;
         }
 
         final PropertyAnimator animator = new PropertyAnimator(250);
         animator.setUseHardwareLayer(false);
 
         mBrowserToolbar.startEditing(url, animator);
 
-        final boolean isUserSearchTerm = selectedTab != null &&
-                !TextUtils.isEmpty(selectedTab.getUserRequested());
         showHomePagerWithAnimator(panelId, null, animator);
 
         animator.start();
         Telemetry.startUISession(TelemetryContract.Session.AWESOMESCREEN);
     }
 
     private void commitEditingMode() {
         if (!mBrowserToolbar.isEditing()) {