Bug 1277378 - Fix typo in Safe Browsing in-content preferences. r?past draft
authorFrancois Marier <francois@mozilla.com>
Wed, 01 Jun 2016 16:35:48 -0700
changeset 374138 3a519f68017dbd840e91e0812eaef39b75c3dafd
parent 373935 111970c738234569c8c180319155327316335deb
child 522564 3224b1756e8f6b78522eb69a12227f0b9d985034
push id19943
push userfmarier@mozilla.com
push dateWed, 01 Jun 2016 23:41:25 +0000
reviewerspast
bugs1277378
milestone49.0a1
Bug 1277378 - Fix typo in Safe Browsing in-content preferences. r?past MozReview-Commit-ID: KfZpVRWuzjV
browser/components/preferences/in-content/security.js
browser/components/preferences/in-content/tests/browser_security.js
--- a/browser/components/preferences/in-content/security.js
+++ b/browser/components/preferences/in-content/security.js
@@ -184,20 +184,20 @@ var gSecurityPane = {
     });
 
     blockUncommonUnwanted.addEventListener("command", function() {
       blockUnwantedPref.value = blockUncommonUnwanted.checked;
       blockUncommonPref.value = blockUncommonUnwanted.checked;
 
       let malware = malwareTable.value
         .split(",")
-        .filter(x => x !== "goog-unwanted-simple" && x !== "test-unwanted-simple");
+        .filter(x => x !== "goog-unwanted-shavar" && x !== "test-unwanted-simple");
 
       if (blockUncommonUnwanted.checked) {
-        malware.push("goog-unwanted-simple");
+        malware.push("goog-unwanted-shavar");
         malware.push("test-unwanted-simple");
       }
 
       // sort alphabetically to keep the pref consistent
       malware.sort();
 
       malwareTable.value = malware.join(",");
     });
--- a/browser/components/preferences/in-content/tests/browser_security.js
+++ b/browser/components/preferences/in-content/tests/browser_security.js
@@ -107,18 +107,18 @@ add_task(function*() {
     // check that both settings are now turned on or off
     is(Services.prefs.getBoolPref("browser.safebrowsing.downloads.remote.block_potentially_unwanted"), !checked,
        "block_potentially_unwanted is set correctly");
     is(Services.prefs.getBoolPref("browser.safebrowsing.downloads.remote.block_uncommon"), !checked,
        "block_uncommon is set correctly");
 
     // when the preference is on, the malware table should include these ids
     let malwareTable = Services.prefs.getCharPref("urlclassifier.malwareTable").split(",");
-    is(malwareTable.includes("goog-unwanted-simple"), !checked,
-       "malware table doesn't include goog-unwanted-simple");
+    is(malwareTable.includes("goog-unwanted-shavar"), !checked,
+       "malware table doesn't include goog-unwanted-shavar");
     is(malwareTable.includes("test-unwanted-simple"), !checked,
        "malware table doesn't include test-unwanted-simple");
     let sortedMalware = malwareTable.slice(0);
     sortedMalware.sort();
     Assert.deepEqual(malwareTable, sortedMalware, "malware table has been sorted");
 
     yield BrowserTestUtils.removeTab(gBrowser.selectedTab);
   }