Bug 1251134 - Remove redundant check for the panel state that is checked after a yield on a potential slow Places query. r?gijs draft
authorJared Wein <jwein@mozilla.com>
Wed, 01 Jun 2016 15:34:47 -0400
changeset 374096 4e4346ee68062763ce9d45f672dc92a3dc847184
parent 371311 25566a14a7ac98674bfe9b6e73edc59fcc286c22
child 522544 9af5dfb55d0b849b88f4e5d056baa5505d3679a9
push id19922
push userjwein@mozilla.com
push dateWed, 01 Jun 2016 19:35:14 +0000
reviewersgijs
bugs1251134
milestone49.0a1
Bug 1251134 - Remove redundant check for the panel state that is checked after a yield on a potential slow Places query. r?gijs MozReview-Commit-ID: L46711lTbPC
browser/base/content/test/general/browser_bookmark_popup.js
--- a/browser/base/content/test/general/browser_bookmark_popup.js
+++ b/browser/base/content/test/general/browser_bookmark_popup.js
@@ -37,17 +37,16 @@ function* test_bookmarks_popup({isNewBoo
 
     if (popupEditFn) {
       yield popupEditFn();
     }
     let bookmarks = [];
     yield PlacesUtils.bookmarks.fetch({url: "about:home"}, bm => bookmarks.push(bm));
     is(bookmarks.length, 1, "Only one bookmark should exist");
     is(bookmarkStar.getAttribute("starred"), "true", "Page is starred");
-    is(bookmarkPanel.state, "open", "Check that panel state is 'open'");
     is(bookmarkPanelTitle.value,
       isNewBookmark ?
         gNavigatorBundle.getString("editBookmarkPanel.pageBookmarkedTitle") :
         gNavigatorBundle.getString("editBookmarkPanel.editBookmarkTitle"),
       "title should match isEditingBookmark state");
 
     if (!shouldAutoClose) {
       yield new Promise(resolve => setTimeout(resolve, 400));