Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r?margaret draft
authorSebastian Kaspari <s.kaspari@gmail.com>
Wed, 01 Jun 2016 10:02:51 +0200
changeset 373774 4f91aea87e161fa08d07677f5c90717e7514e59c
parent 373202 dc4d7f68030e9edd22ad0bb0bd2244d047dd767d
child 522470 5934bc7f89a7bdeb1283708ecac953546f5b8179
push id19841
push users.kaspari@gmail.com
push dateWed, 01 Jun 2016 08:03:27 +0000
reviewersmargaret
bugs1276910
milestone49.0a1
Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r?margaret MozReview-Commit-ID: DFoMnyx4Gde
mobile/android/base/java/org/mozilla/gecko/promotion/AddToHomeScreenPromotion.java
--- a/mobile/android/base/java/org/mozilla/gecko/promotion/AddToHomeScreenPromotion.java
+++ b/mobile/android/base/java/org/mozilla/gecko/promotion/AddToHomeScreenPromotion.java
@@ -129,16 +129,21 @@ public class AddToHomeScreenPromotion ex
             // We only ever want to show this promotion for the current tab.
             return;
         }
 
         if (Tabs.TabEvents.LOADED != msg) {
             return;
         }
 
+        if (tab.isPrivate()) {
+            // Never show the prompt for private browsing tabs.
+            return;
+        }
+
         if (!isInForeground) {
             // We only want to show this prompt if this tab is in the foreground and not on top
             // of the tabs tray.
             return;
         }
 
         ThreadUtils.postToBackgroundThread(new Runnable() {
             @Override