Bug 1276132 - Make more Widevine class constructors explicit to keep gcc happy. r=jwwang draft
authorChris Pearce <cpearce@mozilla.com>
Tue, 31 May 2016 12:05:24 +1200
changeset 374274 ad40a29d0ceb8ea44eba61b28a86d89199e2d8f6
parent 374273 c198d6613c04df0d9889a6121606498e883ff607
child 522592 294c5f8da281aabdd5eff53af5d4f6f5b8129221
push id19972
push usercpearce@mozilla.com
push dateThu, 02 Jun 2016 04:16:40 +0000
reviewersjwwang
bugs1276132
milestone49.0a1
Bug 1276132 - Make more Widevine class constructors explicit to keep gcc happy. r=jwwang Fixes compile errors on Linux when Widevine is compiled. MozReview-Commit-ID: 19qQw02CqdQ
dom/media/gmp/widevine-adapter/WidevineDecryptor.cpp
dom/media/gmp/widevine-adapter/WidevineUtils.h
--- a/dom/media/gmp/widevine-adapter/WidevineDecryptor.cpp
+++ b/dom/media/gmp/widevine-adapter/WidevineDecryptor.cpp
@@ -188,17 +188,17 @@ WidevineDecryptor::DecryptingComplete()
   Log("WidevineDecryptor::DecryptingComplete() this=%p", this);
   mCDM = nullptr;
   mCallback = nullptr;
   Release();
 }
 
 class WidevineBuffer : public cdm::Buffer {
 public:
-  WidevineBuffer(size_t aSize) {
+  explicit WidevineBuffer(size_t aSize) {
     Log("WidevineBuffer(size=" PRIuSIZE ") created", aSize);
     mBuffer.SetLength(aSize);
   }
   ~WidevineBuffer() {
     Log("WidevineBuffer(size=" PRIuSIZE ") destroyed", Size());
   }
   void Destroy() override { delete this; }
   uint32_t Capacity() const override { return mBuffer.Length(); };
--- a/dom/media/gmp/widevine-adapter/WidevineUtils.h
+++ b/dom/media/gmp/widevine-adapter/WidevineUtils.h
@@ -41,17 +41,17 @@ Log(const char* aFormat, ...);
 
 GMPErr
 ToGMPErr(cdm::Status aStatus);
 
 class CDMWrapper {
 public:
   NS_INLINE_DECL_THREADSAFE_REFCOUNTING(CDMWrapper)
 
-  CDMWrapper(cdm::ContentDecryptionModule_8* aCDM)
+  explicit CDMWrapper(cdm::ContentDecryptionModule_8* aCDM)
     : mCDM(aCDM)
   {
     MOZ_ASSERT(mCDM);
   }
   cdm::ContentDecryptionModule_8* GetCDM() const { return mCDM; }
 private:
   cdm::ContentDecryptionModule_8* mCDM;
   ~CDMWrapper() {