Bug 1237885 - Remove browser_rules_add-rule_05.js; r=jdescottes draft
authorPatrick Brosset <pbrosset@mozilla.com>
Mon, 30 May 2016 12:50:08 +0200
changeset 372843 ce2d3885ec34c4c1ed591c6d1852889a183fe275
parent 372842 fba6328cfa4ee6d8085184a49ee123f9ac11966b
child 372844 bfbe4957075299954617eb42de8e0b6d4d230d95
push id19604
push userpbrosset@mozilla.com
push dateMon, 30 May 2016 11:03:14 +0000
reviewersjdescottes
bugs1237885
milestone49.0a1
Bug 1237885 - Remove browser_rules_add-rule_05.js; r=jdescottes This test is now useless if you consider browser_rules_add-rule_01.js and browser_rules_add-rule-and-property.js MozReview-Commit-ID: IlqDhEHUK1m
devtools/client/inspector/rules/test/browser.ini
devtools/client/inspector/rules/test/browser_rules_add-rule_05.js
--- a/devtools/client/inspector/rules/test/browser.ini
+++ b/devtools/client/inspector/rules/test/browser.ini
@@ -46,17 +46,16 @@ support-files =
 [browser_rules_add-property-commented.js]
 [browser_rules_add-property_01.js]
 [browser_rules_add-property_02.js]
 [browser_rules_add-property-svg.js]
 [browser_rules_add-rule_01.js]
 [browser_rules_add-rule_02.js]
 [browser_rules_add-rule_03.js]
 [browser_rules_add-rule_04.js]
-[browser_rules_add-rule_05.js]
 [browser_rules_add-rule_06.js]
 [browser_rules_add-rule-and-property.js]
 [browser_rules_add-rule_pseudo_class.js]
 [browser_rules_add-rule_iframes.js]
 [browser_rules_add-rule-with-menu.js]
 [browser_rules_authored.js]
 [browser_rules_authored_color.js]
 [browser_rules_authored_override.js]
deleted file mode 100644
--- a/devtools/client/inspector/rules/test/browser_rules_add-rule_05.js
+++ /dev/null
@@ -1,59 +0,0 @@
-/* vim: set ft=javascript ts=2 et sw=2 tw=80: */
-/* Any copyright is dedicated to the Public Domain.
- http://creativecommons.org/publicdomain/zero/1.0/ */
-
-"use strict";
-
-// Tests the behaviour of adding a new rule to the rule view using the context
-// menu and the various inplace-editor behaviours in the new rule editor.
-
-const TEST_URI = `
-  <style type="text/css">
-    .testclass {
-      text-align: center;
-    }
-  </style>
-  <div id="testid" class="testclass">Styled Node</div>
-  <span class="testclass2">This is a span</span>
-  <span class="class1 class2">Multiple classes</span>
-  <span class="class3      class4">Multiple classes</span>
-  <p>Empty<p>
-  <h1 class="asd@@@@a!!!!:::@asd">Invalid characters in class</h1>
-  <h2 id="asd@@@a!!2a">Invalid characters in id</h2>
-`;
-
-const TEST_DATA = [
-  { node: "#testid", expected: "#testid" },
-  { node: ".testclass2", expected: ".testclass2" },
-  { node: ".class1.class2", expected: ".class1.class2" },
-  { node: ".class3.class4", expected: ".class3.class4" },
-  { node: "p", expected: "p" },
-  { node: "h1", expected: ".asd\\@\\@\\@\\@a\\!\\!\\!\\!\\:\\:\\:\\@asd" },
-  { node: "h2", expected: "#asd\\@\\@\\@a\\!\\!2a" }
-];
-
-add_task(function* () {
-  yield addTab("data:text/html;charset=utf-8," + encodeURIComponent(TEST_URI));
-  let {inspector, view} = yield openRuleView();
-
-  for (let data of TEST_DATA) {
-    let {node, expected} = data;
-    yield selectNode(node, inspector);
-    yield testNewRule(inspector, view, expected);
-  }
-});
-
-function* testNewRule(inspector, view, expected) {
-  yield addNewRuleAndDismissEditor(inspector, view, expected, 1);
-
-  info("Adding new properties to new rule: " + expected);
-  let ruleEditor = getRuleViewRuleEditor(view, 1);
-  let onRuleViewChanged = view.once("ruleview-changed");
-  ruleEditor.addProperty("font-weight", "bold", "");
-  yield onRuleViewChanged;
-
-  let textProps = ruleEditor.rule.textProps;
-  let lastRule = textProps[textProps.length - 1];
-  is(lastRule.name, "font-weight", "Last rule name is font-weight");
-  is(lastRule.value, "bold", "Last rule value is bold");
-}