Bug 1237885 - Remove duplicated addNewRule code from ruleview tests; r=jdescottes
MozReview-Commit-ID: HqUaFFWiTym
--- a/devtools/client/inspector/rules/test/browser_rules_add-rule_iframes.js
+++ b/devtools/client/inspector/rules/test/browser_rules_add-rule_iframes.js
@@ -29,24 +29,16 @@ add_task(function* () {
let innerFrameDiv2 = yield getNodeFrontInFrame("div", "#frame2", inspector);
yield selectNode(innerFrameDiv2, inspector);
yield addNewRule(inspector, view);
yield testNewRule(view, "div", 1);
yield addNewProperty(view, 1, "color", "green");
});
-function* addNewRule(inspector, view) {
- info("Adding the new rule using the button");
- view.addRuleButton.click();
- info("Waiting for rule view to change");
- let onRuleViewChanged = once(view, "ruleview-changed");
- yield onRuleViewChanged;
-}
-
/**
* Check the newly created rule has the expected selector and submit the
* selector editor.
*/
function* testNewRule(view, expected, index) {
let idRuleEditor = getRuleViewRuleEditor(view, index);
let editor = idRuleEditor.selectorText.ownerDocument.activeElement;
is(editor.value, expected,
--- a/devtools/client/inspector/rules/test/browser_rules_add-rule_pseudo_class.js
+++ b/devtools/client/inspector/rules/test/browser_rules_add-rule_pseudo_class.js
@@ -31,24 +31,16 @@ add_task(function* () {
function* runTestData(inspector, view, pseudoClasses) {
yield setPseudoLocks(inspector, view, pseudoClasses);
yield addNewRule(inspector, view);
yield testNewRule(view, pseudoClasses, 1);
yield resetPseudoLocks(inspector, view);
}
-function* addNewRule(inspector, view) {
- info("Adding the new rule using the button");
- view.addRuleButton.click();
- info("Waiting for rule view to change");
- let onRuleViewChanged = once(view, "ruleview-changed");
- yield onRuleViewChanged;
-}
-
function* testNewRule(view, pseudoClasses, index) {
let idRuleEditor = getRuleViewRuleEditor(view, index);
let editor = idRuleEditor.selectorText.ownerDocument.activeElement;
let expected = EXPECTED_SELECTOR + pseudoClasses.join("");
is(editor.value, expected,
"Selector editor value is as expected: " + expected);