Bug 1162050 - Remove the dragdrop event code that is not related to the drop event in from EventStateManager.cpp. draft
authorJimmy Wang <jimmyw22@gmail.com>
Fri, 27 May 2016 14:50:30 -0400
changeset 386639 807bbb0ab5ccd5081ffaeaf5443e5d3ef1073636
parent 386638 70c97ba0c9c67d3220f1a02159b6703c351a014d
child 386640 32f7995adeff725d4a5603e5e2de2cfcac0bc98b
push id22751
push userjimmyw22@gmail.com
push dateTue, 12 Jul 2016 10:57:58 +0000
bugs1162050
milestone50.0a1
Bug 1162050 - Remove the dragdrop event code that is not related to the drop event in from EventStateManager.cpp. MozReview-Commit-ID: Jxf9dXgxJ14
dom/events/EventStateManager.cpp
--- a/dom/events/EventStateManager.cpp
+++ b/dom/events/EventStateManager.cpp
@@ -3427,42 +3427,16 @@ EventStateManager::PostHandleEvent(nsPre
         // this.
         initialDataTransfer->SetDropEffectInt(dropEffect);
       }
     }
     break;
 
   case eDrop:
     {
-      // now fire the dragdrop event, for compatibility with XUL
-      if (mCurrentTarget && nsEventStatus_eConsumeNoDefault != *aStatus) {
-        nsCOMPtr<nsIContent> targetContent;
-        mCurrentTarget->GetContentForEvent(aEvent,
-                                           getter_AddRefs(targetContent));
-
-        nsCOMPtr<nsIWidget> widget = mCurrentTarget->GetNearestWidget();
-        WidgetDragEvent event(aEvent->IsTrusted(), eLegacyDragDrop, widget);
-
-        WidgetMouseEvent* mouseEvent = aEvent->AsMouseEvent();
-        event.mRefPoint = mouseEvent->mRefPoint;
-        if (mouseEvent->mWidget) {
-          event.mRefPoint += mouseEvent->mWidget->WidgetToScreenOffset();
-        }
-        event.mRefPoint -= widget->WidgetToScreenOffset();
-        event.mModifiers = mouseEvent->mModifiers;
-        event.buttons = mouseEvent->buttons;
-        event.inputSource = mouseEvent->inputSource;
-
-        nsEventStatus status = nsEventStatus_eIgnore;
-        nsCOMPtr<nsIPresShell> presShell = mPresContext->GetPresShell();
-        if (presShell) {
-          presShell->HandleEventWithTarget(&event, mCurrentTarget,
-                                           targetContent, &status);
-        }
-      }
       sLastDragOverFrame = nullptr;
       ClearGlobalActiveContent(this);
       break;
     }
   case eDragExit:
      // make sure to fire the enter and exit_synth events after the
      // eDragExit event, otherwise we'll clean up too early
     GenerateDragDropEnterExit(presContext, aEvent->AsDragEvent());