Bug 1275538: P1. Abort early if a skip request is in progress. r?kamidphish draft
authorJean-Yves Avenard <jyavenard@mozilla.com>
Thu, 26 May 2016 13:59:46 +1000
changeset 371186 bb7917317b7aacea69ea0a2ee997db989b7a4746
parent 371122 8d0aadfe7da782d415363880008b4ca027686137
child 371187 68ad431f0a8ffbccef72a86822e962c65ca27711
push id19275
push userbmo:jyavenard@mozilla.com
push dateThu, 26 May 2016 05:33:14 +0000
reviewerskamidphish
bugs1275538
milestone49.0a1
Bug 1275538: P1. Abort early if a skip request is in progress. r?kamidphish We would only abort early if new data had been received. Which may not always be the case. MozReview-Commit-ID: HvAUq5CTc7F
dom/media/MediaFormatReader.cpp
--- a/dom/media/MediaFormatReader.cpp
+++ b/dom/media/MediaFormatReader.cpp
@@ -1099,16 +1099,21 @@ MediaFormatReader::Update(TrackType aTra
   bool needOutput = false;
   auto& decoder = GetDecoderData(aTrack);
   decoder.mUpdateScheduled = false;
 
   if (!mInitDone) {
     return;
   }
 
+  if (aTrack == TrackType::kVideoTrack && mSkipRequest.Exists()) {
+    LOGV("Skipping in progress, nothing more to do");
+    return;
+  }
+
   if (UpdateReceivedNewData(aTrack)) {
     LOGV("Nothing more to do");
     return;
   }
 
   if (decoder.mSeekRequest.Exists()) {
     LOGV("Seeking hasn't completed, nothing more to do");
     return;