Bug 1275437 - Changed flags passed to pacman in Windows bootstrapper to be the --long-form instead of the single character flag. r?gps draft
authorNathan Hakkakzadeh <nhakkakzadeh@mozilla.com>
Wed, 25 May 2016 14:20:38 -0700
changeset 371127 e5a56297b4424a49c57abaf88dcb7fe78640f1a0
parent 371126 458031822f69284e433c410e57738252af4b6b7c
child 521911 cbfa66d258f6b88a70e6dc29a24de5ae2e38d2bf
push id19238
push userbmo:nhakkakzadeh@mozilla.com
push dateWed, 25 May 2016 23:32:47 +0000
reviewersgps
bugs1275437
milestone49.0a1
Bug 1275437 - Changed flags passed to pacman in Windows bootstrapper to be the --long-form instead of the single character flag. r?gps This will make it easier to read for people who are not familiar with pacman. MozReview-Commit-ID: BDzSV8GZ7er
python/mozboot/mozboot/windows.py
--- a/python/mozboot/mozboot/windows.py
+++ b/python/mozboot/mozboot/windows.py
@@ -66,22 +66,24 @@ class WindowsBootstrapper(BaseBootstrapp
 
     def _update_package_manager(self):
         self.pacman_update()
 
     def run(self, command):
         subprocess.check_call(command, stdin=sys.stdin)
 
     def pacman_update(self):
-        command = ['pacman', '-S', '--refresh']
+        command = ['pacman', '--sync', '--refresh']
         self.run(command)
 
     def pacman_upgrade(self):
-        command = ['pacman', '-Syu']
+        command = ['pacman', '--sync', '--refresh', '--sysupgrade']
         self.run(command)
 
     def pacman_install(self, *packages):
-        command = ['pacman', '-S', '--needed']
+        command = ['pacman', '--sync', '--needed']
         if self.no_interactive:
             command.append('--noconfirm')
 
         command.extend(packages)
         self.run(command)
+
+