Bug 1275297 - Write MinimumVisualStudioVersion to solution file; r?chmanchester draft
authorGregory Szorc <gps@mozilla.com>
Tue, 24 May 2016 08:14:06 -0700
changeset 370386 043e6eb0a33da1c4d8c060bba4f842aa557056ae
parent 370385 4dbf3bb3f333a8d90c29579774965813ccae8e8e
child 370387 5ca439eb22755bacbf86912bcb9e16684550ea76
push id19044
push userbmo:gps@mozilla.com
push dateTue, 24 May 2016 15:48:33 +0000
reviewerschmanchester
bugs1275297
milestone49.0a1
Bug 1275297 - Write MinimumVisualStudioVersion to solution file; r?chmanchester Visual Studio will write this variable to an ancient Visual Studio version (2010 I believe) if we don't specify it. Explicitly write the variable to the minimum Visual Studio version we support. MozReview-Commit-ID: 8Y0im48OM2G
python/mozbuild/mozbuild/backend/visualstudio.py
--- a/python/mozbuild/mozbuild/backend/visualstudio.py
+++ b/python/mozbuild/mozbuild/backend/visualstudio.py
@@ -256,16 +256,19 @@ class VisualStudioBackend(CommonBackend)
         # This is a Visual C++ Project type.
         project_type = '8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942'
 
         # Visual Studio seems to require this header.
         fh.write('Microsoft Visual Studio Solution File, Format Version %s\r\n' %
                  format_version)
         fh.write('# Visual Studio %s\r\n' % comment_version)
 
+        # Corresponds to VS2013.
+        fh.write('MinimumVisualStudioVersion = 12.0.31101.0\r\n')
+
         binaries_id = projects['target_binaries'][0]
 
         # Write out entries for each project.
         for key in sorted(projects):
             project_id, basename, name = projects[key]
             path = os.path.join(self._projsubdir, '%s.vcxproj' % basename)
 
             fh.write('Project("{%s}") = "%s", "%s", "{%s}"\r\n' % (